From: "David Wang" <00107082@163.com>
To: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
Cc: "Florian Westphal" <fw@strlen.de>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@google.com>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re:Re: [PATCH] samples/bpf: Add sample usage for BPF_PROG_TYPE_NETFILTER
Date: Wed, 6 Sep 2023 00:06:53 +0800 (CST) [thread overview]
Message-ID: <2fda69d6.5c09.18a6618c48a.Coremail.00107082@163.com> (raw)
In-Reply-To: <CAADnVQKK-xGL55aYyhv-bWRizi5Ymp75c=Qwhu4y4v8DQK1s+g@mail.gmail.com>
At 2023-09-05 23:49:41, "Alexei Starovoitov" <alexei.starovoitov@gmail.com> wrote:
>On Tue, Sep 5, 2023 at 4:11 AM David Wang <00107082@163.com> wrote:
>> >
>> >Yes, but only in selftests/bpf.
>> >samples/bpf/ are not tested and bit rot heavily.
>>
>> Hi Alexei,
>>
>> I need to know whether samples/bpf is still a good place to put code.
>> I will put the code in another open source project for bpf samples, mentioned by Toke.
>> But I still want to put it in samples/bpf , since the code only compile/work with new kernel.
>>
>> Need your feedback on this, could this code be kept in samples/bpf? :)
>
>Sorry, but we don't accept new code to samples/bpf/.
>Everything in there will be moved/removed.
>If you want to stay in the kernel selftests/bpf is the only place and
>it's gotta be the real test and not just a sample.
Sad to hear this....
Anyway, thank you and all others who took time reviewing this.
David
next prev parent reply other threads:[~2023-09-05 19:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 10:21 [PATCH] samples/bpf: Add sample usage for BPF_PROG_TYPE_NETFILTER David Wang
2023-09-04 10:48 ` Florian Westphal
2023-09-04 11:10 ` David Wang
2023-09-04 11:29 ` David Wang
2023-09-04 21:01 ` [PATCH] samples/bpf: Add sample usage for BPF_PROG_TYPE_NETFILTER Alexei Starovoitov
2023-09-05 3:16 ` David Wang
2023-09-05 8:41 ` Toke Høiland-Jørgensen
2023-09-05 10:52 ` David Wang
2023-09-05 11:09 ` David Wang
2023-09-05 15:49 ` Alexei Starovoitov
2023-09-05 16:06 ` David Wang [this message]
2023-09-05 9:05 ` Donald Hunter
2023-09-05 10:57 ` David Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fda69d6.5c09.18a6618c48a.Coremail.00107082@163.com \
--to=00107082@163.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=fw@strlen.de \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox