From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, kafai@meta.com, kernel-team@meta.com,
Mykyta Yatsenko <yatsenko@meta.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: implement setting global variables in veristat
Date: Wed, 05 Feb 2025 17:29:03 -0800 [thread overview]
Message-ID: <304d5081ef18c3d933d5d0bb79579922d74437a0.camel@gmail.com> (raw)
In-Reply-To: <CAEf4BzayxsGSj5n3A6HAYgg3QC5xFvNcXrCHgLCqiWMj=0EP6w@mail.gmail.com>
On Wed, 2025-02-05 at 17:06 -0800, Andrii Nakryiko wrote:
[...]
> but main point from me here would be to avoid parsing multiple values,
> it's better to allow repeated -G uses and treat each value as strictly
> single variable initialization. So instead of:
>
> ./veristat wq.bpf.o --set-global-vars "a = 0; b = 1; c = 2; d = 3;"
>
> we'll have:
>
> ./veristat wq.bpf.o -G "a = 0" -G "b = 1" -G "c = 2" -G "d = 3"
>
> A touch more verbose for many variables, but not significantly so. On
> the other hand, less parsing, and less arbitrary choices of what
> separator (;) to use. WDYT?
>
> pw-bot: cr
In a sibling thread I asked about '-g @file' support, allowing to list
variables in files. This could be worked around as $(cat file) in
the command line, of course.
[...]
next prev parent reply other threads:[~2025-02-06 1:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 16:40 [PATCH bpf-next] selftests/bpf: implement setting global variables in veristat Mykyta Yatsenko
2025-02-03 22:56 ` Eduard Zingerman
2025-02-04 12:29 ` Mykyta Yatsenko
2025-02-06 1:06 ` Andrii Nakryiko
2025-02-06 1:29 ` Eduard Zingerman [this message]
2025-02-06 1:46 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304d5081ef18c3d933d5d0bb79579922d74437a0.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@meta.com \
--cc=kernel-team@meta.com \
--cc=mykyta.yatsenko5@gmail.com \
--cc=yatsenko@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox