From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fra-out-010.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-010.esa.eu-central-1.outbound.mail-perimeter.amazon.com [63.178.143.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B25DF3C0087; Thu, 15 Jan 2026 17:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.178.143.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499178; cv=none; b=NTe+bV/AH3OtQJZe15y2UAZN2WL9TArDuoczLdSuNBtw/ue9ozxmwP2ZW8cmeRdnOOShffSu4dJ0/ImpBo22GV6BsHHcRYfG8uwwpamAWzivmSyNIimFTu4PlnPoQPpvM1N/Q+8yIvWPReqBlATRQZgXlZ1VLDzhsK4QWJ6gHaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499178; c=relaxed/simple; bh=qtUAulfTwQotnNV2eCERFGBmXc11oEOyEFJE9Mbe1u0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=c2CKbDeTdg2pFZLwCVkuLaAaC7jK/tNx+IZmuSigJQP6oPwFTLbrbI1mIfJ/aQdMWZcGUTIi7G6akNmv5aOBJdJUrdXS9hFn/5iN0eujIq4KQgTEQGiirLRhUf/rRr2pJsqH7vhbcBjaPCtuJ1FtpbirKQcLsR4TAHJ3WBwT8kA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=qB+41U6q; arc=none smtp.client-ip=63.178.143.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="qB+41U6q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1768499176; x=1800035176; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=m/H+6KLBn2aGntJJ8JBW+O36kdoVRhTXFh0DlSdS7kQ=; b=qB+41U6qnQEH/k8iSLvNEvt4qCnhYF/jLgKeWaqqeHFZsvx8SvTNdVu2 8rLkmKHSXC3Vn2xen1KZjXd6oL3mZbndImFfiPBnXsBZ60Clz4tA+nq4m FXHFFw9gKztAf+AhMdZKPlVT74KI9LzV9PmRIV/mCgWIRD5+fiHxXhB3J 5039ZHp6UansEQCJuKeeQv60f2FNMUnO20U/9QIJLD+zbquTSHFIvpsM+ EWHQwyfbQoGvENkbepoRtLgvg+7fFX0oJV/mwbtboR/RafyDgitiou16v LgngTYrTmfDx0nTmfA/Kitt12o1wD1fjdDHDN2fXV73fiyOu7D2VhGIgk Q==; X-CSE-ConnectionGUID: UZboAnEGTqq8ocdnm/l8TA== X-CSE-MsgGUID: oh7w6HfgSl2x9siR+geNHw== X-IronPort-AV: E=Sophos;i="6.21,228,1763424000"; d="scan'208";a="7872674" Received: from ip-10-6-3-216.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.3.216]) by internal-fra-out-010.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2026 17:45:56 +0000 Received: from EX19MTAEUC001.ant.amazon.com [54.240.197.233:5968] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.2.33:2525] with esmtp (Farcaster) id df1a6986-76b5-4a71-8d9f-e42e7d836f1e; Thu, 15 Jan 2026 17:45:56 +0000 (UTC) X-Farcaster-Flow-ID: df1a6986-76b5-4a71-8d9f-e42e7d836f1e Received: from EX19D005EUB003.ant.amazon.com (10.252.51.31) by EX19MTAEUC001.ant.amazon.com (10.252.51.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Thu, 15 Jan 2026 17:45:53 +0000 Received: from [192.168.15.69] (10.106.82.11) by EX19D005EUB003.ant.amazon.com (10.252.51.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Thu, 15 Jan 2026 17:45:49 +0000 Message-ID: <34b246e9-0f7a-4ed6-9e43-845c4238bf41@amazon.com> Date: Thu, 15 Jan 2026 17:45:48 +0000 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v9 01/13] set_memory: add folio_{zap, restore}_direct_map helpers To: Matthew Wilcox , "Kalyazin, Nikita" CC: "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "loongarch@lists.linux.dev" , "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "akpm@linux-foundation.org" , "david@kernel.org" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "riel@surriel.com" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "ackerleytng@google.com" , "maobibo@loongson.cn" , "prsampat@amd.com" , "mlevitsk@redhat.com" , "jmattson@google.com" , "jthoughton@google.com" , "agordeev@linux.ibm.com" , "alex@ghiti.fr" , "aou@eecs.berkeley.edu" , "borntraeger@linux.ibm.com" , "chenhuacai@kernel.org" , "dev.jain@arm.com" , "gor@linux.ibm.com" , "hca@linux.ibm.com" , "Jonathan.Cameron@huawei.com" , "palmer@dabbelt.com" , "pjw@kernel.org" , "shijie@os.amperecomputing.com" , "svens@linux.ibm.com" , "thuth@redhat.com" , "wyihan@google.com" , "yang@os.amperecomputing.com" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" , "Cali, Marco" References: <20260114134510.1835-1-kalyazin@amazon.com> <20260114134510.1835-2-kalyazin@amazon.com> Content-Language: en-US From: Nikita Kalyazin Autocrypt: addr=kalyazin@amazon.com; keydata= xjMEY+ZIvRYJKwYBBAHaRw8BAQdA9FwYskD/5BFmiiTgktstviS9svHeszG2JfIkUqjxf+/N JU5pa2l0YSBLYWx5YXppbiA8a2FseWF6aW5AYW1hem9uLmNvbT7CjwQTFggANxYhBGhhGDEy BjLQwD9FsK+SyiCpmmTzBQJnrNfABQkFps9DAhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQr5LK IKmaZPOpfgD/exazh4C2Z8fNEz54YLJ6tuFEgQrVQPX6nQ/PfQi2+dwBAMGTpZcj9Z9NvSe1 CmmKYnYjhzGxzjBs8itSUvWIcMsFzjgEY+ZIvRIKKwYBBAGXVQEFAQEHQCqd7/nb2tb36vZt ubg1iBLCSDctMlKHsQTp7wCnEc4RAwEIB8J+BBgWCAAmFiEEaGEYMTIGMtDAP0Wwr5LKIKma ZPMFAmes18AFCQWmz0MCGwwACgkQr5LKIKmaZPNTlQEA+q+rGFn7273rOAg+rxPty0M8lJbT i2kGo8RmPPLu650A/1kWgz1AnenQUYzTAFnZrKSsXAw5WoHaDLBz9kiO5pAK In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX19D004EUC003.ant.amazon.com (10.252.51.249) To EX19D005EUB003.ant.amazon.com (10.252.51.31) On 15/01/2026 15:55, Matthew Wilcox wrote: > On Wed, Jan 14, 2026 at 01:45:23PM +0000, Kalyazin, Nikita wrote: >> +int folio_zap_direct_map(struct folio *folio) >> +{ >> + return set_direct_map_valid_noflush(folio_page(folio, 0), >> + folio_nr_pages(folio), false); >> +} > > The implementation isn't the greatest. None of the implementations > of set_direct_map_valid_noflush() actually do anything with the struct > page; they all call page_address() or page_to_virt() (fundamentally the > same thing). So converting folio->page->address is a bit inefficient. > > It feels like we should change set_direct_map_valid_noflush() to take a > const void * and pass either page_address() or folio_address(), depending > whether the caller has a page or a folio. What do you think? I have nothing against that. execmem_set_direct_map_valid() appears to be the only other user of set_direct_map_valid_noflush() so it isn't going to be a broad change.