BPF List
 help / color / mirror / Atom feed
From: Quentin Monnet <qmo@kernel.org>
To: Yichong Chen <chenyichong@uniontech.com>,
	emil@etsalapatis.com, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com
Cc: martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
	jolsa@kernel.org, jiayuan.chen@linux.dev, bpf@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] tools/bpf/bpftool: Fix vmlinux BTF state cleanup
Date: Wed, 1 Jul 2026 14:10:04 +0100	[thread overview]
Message-ID: <35754af3-9f0b-4fb5-94fe-ca0a24c72547@kernel.org> (raw)
In-Reply-To: <12A35C14DA710D2E+20260624025055.1574875-1-chenyichong@uniontech.com>

2026-06-24 10:50 UTC+0800 ~ Yichong Chen <chenyichong@uniontech.com>
> This series fixes stale vmlinux BTF state in bpftool batch mode.
> 
> Patch 1 resets the map command cached vmlinux BTF pointer when the
> command releases it, and avoids freeing the cached object from the
> map lookup path.
> 
> Patch 2 resets the struct_ops command cached vmlinux BTF pointer and
> dependent cached map info state after each struct_ops command.
> 
> Changes in v4:
> - Add Emil's Reviewed-by tag to patch 1.
> - Inline the struct_ops cleanup instead of adding a helper.
> 
> Changes in v3:
> - Add Fixes tags to both patches.
> 
> Changes in v2:
> - Fold the map lookup path fix into patch 1.
> - Update patch 1 subject and commit message to cover map commands
>   rather than only map dump.
> 
> Yichong Chen (2):
>   tools/bpf/bpftool: Reset vmlinux BTF after map commands
>   tools/bpf/bpftool: Reset vmlinux BTF after struct_ops commands
> 
>  tools/bpf/bpftool/map.c        | 12 +++++++++---
>  tools/bpf/bpftool/struct_ops.c |  4 ++++
>  2 files changed, 13 insertions(+), 3 deletions(-)
> 

Both patches look good, thank you for following up with these fixes!

Reviewed-by: Quentin Monnet <qmo@kernel.org>

  reply	other threads:[~2026-07-01 13:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24  2:50 [PATCH v4 0/2] tools/bpf/bpftool: Fix vmlinux BTF state cleanup Yichong Chen
2026-07-01 13:10 ` Quentin Monnet [this message]
2026-07-01 18:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35754af3-9f0b-4fb5-94fe-ca0a24c72547@kernel.org \
    --to=qmo@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=chenyichong@uniontech.com \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=jiayuan.chen@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox