From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: brouer@redhat.com, lorenzo.bianconi@redhat.com,
davem@davemloft.net, kuba@kernel.org, ast@kernel.org,
daniel@iogearbox.net, shayagr@amazon.com,
john.fastabend@gmail.com, dsahern@kernel.org,
echaudro@redhat.com, jasowang@redhat.com,
alexander.duyck@gmail.com, saeed@kernel.org,
maciej.fijalkowski@intel.com, magnus.karlsson@intel.com,
tirthendu.sarkar@intel.com, toke@redhat.com
Subject: Re: [PATCH v20 bpf-next 23/23] xdp: disable XDP_REDIRECT for xdp multi-buff
Date: Sat, 11 Dec 2021 07:49:56 +0100 [thread overview]
Message-ID: <35b5bf44-3901-1d75-99d0-43c98def22b9@redhat.com> (raw)
In-Reply-To: <a6b33109dea5e82d975ea1ee229f7714d0ffdf77.1639162846.git.lorenzo@kernel.org>
On 10/12/2021 20.14, Lorenzo Bianconi wrote:
> XDP_REDIRECT is not fully supported yet for xdp multi-buff since not
> all XDP capable drivers can map non-linear xdp_frame in ndo_xdp_xmit
> so disable it for the moment.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
LGTM you addressed my last review comments.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
I do expect followup patches that add support for ndo_xdp_xmit in drivers...
> net/core/filter.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 14860931733d..def6e9f451a7 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -4186,6 +4186,13 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp,
> struct bpf_map *map;
> int err;
>
> + /* XDP_REDIRECT is not fully supported yet for xdp multi-buff since
> + * not all XDP capable drivers can map non-linear xdp_frame in
> + * ndo_xdp_xmit.
> + */
> + if (unlikely(xdp_buff_is_mb(xdp) && map_type != BPF_MAP_TYPE_CPUMAP))
> + return -EOPNOTSUPP;
> +
> ri->map_id = 0; /* Valid map id idr range: [1,INT_MAX[ */
> ri->map_type = BPF_MAP_TYPE_UNSPEC;
>
>
next prev parent reply other threads:[~2021-12-11 6:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 19:14 [PATCH v20 bpf-next 00/23] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 01/23] net: skbuff: add size metadata to skb_shared_info for xdp Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 02/23] xdp: introduce flags field in xdp_buff/xdp_frame Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 03/23] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2021-12-11 0:09 ` John Fastabend
2021-12-10 19:14 ` [PATCH v20 bpf-next 04/23] net: mvneta: simplify mvneta_swbm_add_rx_fragment management Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 05/23] net: xdp: add xdp_update_skb_shared_info utility routine Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 06/23] net: marvell: rely on " Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 07/23] xdp: add multi-buff support to xdp_return_{buff/frame} Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 08/23] net: mvneta: add multi buffer support to XDP_TX Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 09/23] bpf: introduce BPF_F_XDP_MB flag in prog_flags loading the ebpf program Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 10/23] net: mvneta: enable jumbo frames if the loaded XDP program support mb Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 11/23] bpf: introduce bpf_xdp_get_buff_len helper Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 12/23] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API Lorenzo Bianconi
2021-12-11 0:11 ` John Fastabend
2021-12-10 19:14 ` [PATCH v20 bpf-next 13/23] bpf: add multi-buffer support to xdp copy helpers Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 14/23] bpf: move user_size out of bpf_test_init Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 15/23] bpf: introduce multibuff support to bpf_prog_test_run_xdp() Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 16/23] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 17/23] bpf: selftests: update xdp_adjust_tail selftest to include multi-buffer Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 18/23] libbpf: Add SEC name for xdp_mb programs Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 19/23] bpf: generalise tail call map compatibility check Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 20/23] net: xdp: introduce bpf_xdp_pointer utility routine Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 21/23] bpf: selftests: introduce bpf_xdp_{load,store}_bytes selftest Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 22/23] bpf: selftests: add CPUMAP/DEVMAP selftests for xdp multi-buff Lorenzo Bianconi
2021-12-10 19:14 ` [PATCH v20 bpf-next 23/23] xdp: disable XDP_REDIRECT " Lorenzo Bianconi
2021-12-11 6:49 ` Jesper Dangaard Brouer [this message]
2021-12-11 0:16 ` [PATCH v20 bpf-next 00/23] mvneta: introduce XDP multi-buffer support John Fastabend
2021-12-11 17:38 ` Toke Høiland-Jørgensen
2021-12-28 14:45 ` Lorenzo Bianconi
2021-12-30 2:07 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35b5bf44-3901-1d75-99d0-43c98def22b9@redhat.com \
--to=jbrouer@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=echaudro@redhat.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=shayagr@amazon.com \
--cc=tirthendu.sarkar@intel.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox