From: Eduard Zingerman <eddyz87@gmail.com>
To: Amery Hung <ameryhung@gmail.com>, bpf@vger.kernel.org
Cc: daniel@iogearbox.net, andrii@kernel.org,
alexei.starovoitov@gmail.com, martin.lau@kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH bpf-next v5 1/3] selftests/bpf: Clean up call sites of stdio_restore()
Date: Wed, 05 Mar 2025 13:42:57 -0800 [thread overview]
Message-ID: <38fde1c64ed58c96b08ff3f42e4c57f3698fadde.camel@gmail.com> (raw)
In-Reply-To: <20250305182057.2802606-1-ameryhung@gmail.com>
On Wed, 2025-03-05 at 10:20 -0800, Amery Hung wrote:
> reset_affinity() and save_ns() are only called in run_one_test(). There is
> no need to call stdio_restore() in reset_affinity() and save_ns() if
> stdio_restore() is moved right after a test finishes in run_one_test().
>
> Also remove an unnecessary check of env.stdout_saved in crash_handler()
> by moving env.stdout_saved assignment to the beginning of main().
>
> Signed-off-by: Amery Hung <ameryhung@gmail.com>
> ---
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
(Thank you for adjusting the commit message, please don't drop acks)
[...]
next prev parent reply other threads:[~2025-03-05 21:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 18:20 [PATCH bpf-next v5 1/3] selftests/bpf: Clean up call sites of stdio_restore() Amery Hung
2025-03-05 18:20 ` [PATCH bpf-next v5 2/3] selftests/bpf: Allow assigning traffic monitor print function Amery Hung
2025-03-05 18:20 ` [PATCH bpf-next v5 3/3] selftests/bpf: Fix dangling stdout seen by traffic monitor thread Amery Hung
2025-03-05 21:43 ` Eduard Zingerman
2025-03-05 21:42 ` Eduard Zingerman [this message]
2025-03-06 22:20 ` [PATCH bpf-next v5 1/3] selftests/bpf: Clean up call sites of stdio_restore() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38fde1c64ed58c96b08ff3f42e4c57f3698fadde.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox