From: David Howells <dhowells@redhat.com>
To: syzbot+62cbf263225ae13ff153@syzkaller.appspotmail.com
Cc: dhowells@redhat.com, Eric Dumazet <edumazet@google.com>,
bpf@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [net?] WARNING in __ip6_append_data
Date: Mon, 18 Sep 2023 11:11:01 +0100 [thread overview]
Message-ID: <3905313.1695031861@warthog.procyon.org.uk> (raw)
In-Reply-To: <CANn89iLwMhOnrmQTZJ+BqZJSbJZ+Q4W6xRknAAr+uSrk5TX-EQ@mail.gmail.com>
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 65d6e954e378
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 0665e8b09968..7978335c1fc4 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -1517,8 +1517,10 @@ static int __ip6_append_data(struct sock *sk,
rt->rt6i_nfheader_len;
if (mtu <= fragheaderlen ||
- ((mtu - fragheaderlen) & ~7) + fragheaderlen <= sizeof(struct frag_hdr))
+ ((mtu - fragheaderlen) & ~7) + fragheaderlen <= sizeof(struct frag_hdr)) {
+ printk("__%u__: EMSGSIZE\n", __LINE__);
goto emsgsize;
+ }
maxfraglen = ((mtu - fragheaderlen) & ~7) + fragheaderlen -
sizeof(struct frag_hdr);
@@ -1526,8 +1528,10 @@ static int __ip6_append_data(struct sock *sk,
/* as per RFC 7112 section 5, the entire IPv6 Header Chain must fit
* the first fragment
*/
- if (headersize + transhdrlen > mtu)
+ if (headersize + transhdrlen > mtu) {
+ printk("__%u__: EMSGSIZE\n", __LINE__);
goto emsgsize;
+ }
if (cork->length + length > mtu - headersize && ipc6->dontfrag &&
(sk->sk_protocol == IPPROTO_UDP ||
@@ -1535,15 +1539,23 @@ static int __ip6_append_data(struct sock *sk,
sk->sk_protocol == IPPROTO_RAW)) {
ipv6_local_rxpmtu(sk, fl6, mtu - headersize +
sizeof(struct ipv6hdr));
+ printk("__%u__: EMSGSIZE\n", __LINE__);
goto emsgsize;
}
- if (ip6_sk_ignore_df(sk))
+ if (ip6_sk_ignore_df(sk)) {
maxnonfragsize = sizeof(struct ipv6hdr) + IPV6_MAXPLEN;
- else
+ printk("MAXPLEN\n");
+ } else {
maxnonfragsize = mtu;
+ printk("mtu\n");
+ }
+ printk("check %d %zd %d %d, %d %d\n",
+ cork->length, length, maxnonfragsize, headersize,
+ transhdrlen, mtu);
if (cork->length + length > maxnonfragsize - headersize) {
+ printk("__%u__: EMSGSIZE\n", __LINE__);
emsgsize:
pmtu = max_t(int, mtu - headersize + sizeof(struct ipv6hdr), 0);
ipv6_local_error(sk, EMSGSIZE, fl6, pmtu);
@@ -1817,8 +1829,10 @@ static int __ip6_append_data(struct sock *sk,
if (!skb_can_coalesce(skb, i, pfrag->page,
pfrag->offset)) {
err = -EMSGSIZE;
- if (i == MAX_SKB_FRAGS)
+ if (i == MAX_SKB_FRAGS) {
+ printk("__%u__: EMSGSIZE\n", __LINE__);
goto error;
+ }
__skb_fill_page_desc(skb, i, pfrag->page,
pfrag->offset, 0);
diff --git a/net/l2tp/l2tp_ip6.c b/net/l2tp/l2tp_ip6.c
index ed8ebb6f5909..daaaf60dce01 100644
--- a/net/l2tp/l2tp_ip6.c
+++ b/net/l2tp/l2tp_ip6.c
@@ -502,6 +502,8 @@ static int l2tp_ip6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
int ulen;
int err;
+ printk("%s()\n", __func__);
+
/* Rough check on arithmetic overflow,
* better check is made in ip6_append_data().
*/
next prev parent reply other threads:[~2023-09-18 10:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 6:19 [syzbot] [net?] WARNING in __ip6_append_data syzbot
2023-09-13 8:41 ` Eric Dumazet
2023-09-15 15:32 ` David Howells
2023-09-15 16:24 ` David Howells
2023-09-18 10:03 ` David Howells
2023-09-18 13:58 ` Willem de Bruijn
2023-09-18 14:04 ` Eric Dumazet
2023-09-19 8:27 ` Tom Parkin
2023-09-19 9:04 ` Eric Dumazet
2023-09-18 14:46 ` David Howells
2023-09-18 10:11 ` David Howells [this message]
2023-09-18 10:33 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3905313.1695031861@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+62cbf263225ae13ff153@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox