From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4F0646D0A3 for ; Tue, 4 Aug 2026 14:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785852538; cv=none; b=rY5vXZCTs2KS18WHAJYTSUYw3UvbmiikKQvvJlTU4Js0w3AFctUUxgIs4wCCRKAjAjvPhKAPIsmDFHljq+KTBmvBeXtn971A3GYg3TAxx9zDsWWYAou1/NxIrSZEY7UcDd/HqIMdjCLhVFYAqbI89wkL2F6YNkeGTDjLV0WE2jc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785852538; c=relaxed/simple; bh=cgYDEwDnXNfrwdk9tVNIwmHDQi12TweMs/BHwBg9tBk=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=dySAMz+8WSDCDoszGliJfN5rZJxVw3E9+HNs6y3rqJzs7h/ooCZ0t/6Jb1EraG/X95QQUK0yCzIQ/Qei6FPqFoGCZBTErKO+Z8PX95g8c7o6QabmNH2Cvu6yZpBbItg9P00ajp7uYbpT48SUhOlhoQlefb3Rh/iIWxYWEwK0ipM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eN5ne6YC; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=H1ZCJj+9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eN5ne6YC"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="H1ZCJj+9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785852535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+LsPDhvpVxFRqbtHPix39kF9hXTlQ+yjqttW+ufqj24=; b=eN5ne6YCXtd8o8lyrvrSZjvrzOOrpvpsvvfe4unb7BHogNNXtnZG+IiwZ83dx8w9fe7Ap8 jBOFlpJuOEDiWjEiVSJjqeeD3079AV5+QpFKEkGln6OMoRnsmjx8tAw7GYAnKjs2UW9tWl mpxJJkWGby70+si7VlBJLG2GDekn2rI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-235-mZcCxumpPXy5gGDGawPyAg-1; Tue, 04 Aug 2026 10:08:43 -0400 X-MC-Unique: mZcCxumpPXy5gGDGawPyAg-1 X-Mimecast-MFC-AGG-ID: mZcCxumpPXy5gGDGawPyAg_1785852522 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47162f83c75so608202f8f.1 for ; Tue, 04 Aug 2026 07:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785852522; x=1786457322; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=+LsPDhvpVxFRqbtHPix39kF9hXTlQ+yjqttW+ufqj24=; b=H1ZCJj+9eEdt4Ke3XwFvc43boHUk+mwdavvplDRItJLJSkv2u3oQFKCobwQ+9fkyWF 5pTv/f6gCiUmihyLcvoh9EaHzA8aC4TjiftB6dcQAs9P4XhmjPUCOZKvzDxjHr6TJDWZ BHItE3OtP7Uq2n4TIeSSpqRCmSL4UM8dKb0v4T0YIjJxZ4rq+/ECG815U1OjUOwc2id6 pmCPIlTb5xfI93+fVtBr9YGRhyQRQ063ANk2aHZMNX8WziTbATF3M6NMbDY8MDNm78Q5 jk/jzPwS9VowkwLqqH1uvEhd02px/SkdISVwarj6T/c4p3Zflm9NVgTp7E0GdLWD6ThJ l9KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785852522; x=1786457322; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=+LsPDhvpVxFRqbtHPix39kF9hXTlQ+yjqttW+ufqj24=; b=JDSQSGsLpH8yqRSc/FSYB4hdNr0wOfO19BBD6os5G4i/ojDkDIBy4iMyzkMMjASS+e u7NmKiFX2A8UC+Az3rhv5z905m2vla/00mP+zC0WMntFN5wziybCWgAktPyvUORN5osD WuyhUZVFDhjXfPTdCZZtX6jKxKzK3k/Sq4DVx7zEQfFR77dYR7c8mchg4UiCo9L1K62U PK3ZSacPFNNuF08HJtUEqDHyAuMu6+JBuMsv3U+jgLTIEbmn6KJvmaZ1aWoOfd/6yVYU /ViTpOQCkq6unFUnnn+pAhkkb1FOQn3Xn6PuGEUcb89Vcm6hNYBejZSC6M0s5e/3gvH+ 5Tnw== X-Forwarded-Encrypted: i=1; AHgh+RqP8ASlqA2hCGd/evCT7Ual30fYmDlpyZVtwKUo8viVQukgta/ZnVD53gxQ1AA/y24nJ5I=@vger.kernel.org X-Gm-Message-State: AOJu0Yywkw5taEMg5ewjPgMlvTRUjsT6Y37oxx7voI9m+rh3qE3fFjXr T7OOWtG06xFpvWVoGxJYZG1JU4Vk3EL1UWrNP1BoJeQVU4ukO8dleKkqwN5oqi99RyWHMVoVA2k ZWQPFm9cssbMMpJBsVInQHb4Hto1wBCwOUIWmPnUap0ZjRTsylKU9rA== X-Gm-Gg: AR+sD13Z29qJ8B3wqJWv3yFfUJubnjP8FmRjUJ4EBcb6AvATqRPKeX5lzFVvE/PzBBh RjYhs/zXJRZfAG4AKc8+Lyfg2Y1GOvQx3hHTKdrADZ9TL6Sd1KQZ1IK8tBlr4igF+HXTAYQW8x/ 9Q5AVloeogW9w/ILh6AxGNuAiJ9AFBztKgkn2+0h0tnNjjNtIiZh4K8pncSRhDGUJq1bnRduFcO 0cX6JUbFIjvdIUVArpXYqJ9yIdJKyWYZMPXE4WUvyWw9Vw/14HSGLmbA4ubUHCtuthd2k2hlfwe KIXhoQVd9sFY/UdWkiayahkrwO6IC+qvTiGLW1mbWUcYfChv2iV9h4NQg8wXmCeceozudWiD3rF 70FtorcyuZGO50wyM5aX9mNC5b+cmMbMZn5ujSmEmnSvJ7hqUWMMGjhpQRsYPlGTax6EYYdgg60 M= X-Received: by 2002:a05:6000:1842:b0:47f:6e8b:699c with SMTP id ffacd0b85a97d-47fe81c299dmr11454153f8f.14.1785852522264; Tue, 04 Aug 2026 07:08:42 -0700 (PDT) X-Received: by 2002:a05:6000:1842:b0:47f:6e8b:699c with SMTP id ffacd0b85a97d-47fe81c299dmr11454036f8f.14.1785852521894; Tue, 04 Aug 2026 07:08:41 -0700 (PDT) Received: from [192.168.188.103] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd456a6d7sm45228918f8f.19.2026.08.04.07.08.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 07:08:41 -0700 (PDT) Message-ID: <3ad893be-c46a-44ba-bcb4-8665eeb41fc2@redhat.com> Date: Tue, 4 Aug 2026 16:08:39 +0200 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 net-next 1/1] tcp: Replace min_tso_segs() with tso_segs() CC callback To: chia-yu.chang@nokia-bell-labs.com, emil@etsalapatis.com, jolsa@kernel.org, yonghong.song@linux.dev, song@kernel.org, linux-kselftest@vger.kernel.org, memxor@gmail.com, shuah@kernel.org, martin.lau@linux.dev, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, horms@kernel.org, dsahern@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org, davem@davemloft.net, edumazet@google.com, andrew+netdev@lunn.ch, donald.hunter@gmail.com, kuniyu@google.com, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com References: <20260730114919.658373-1-chia-yu.chang@nokia-bell-labs.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260730114919.658373-1-chia-yu.chang@nokia-bell-labs.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/30/26 1:49 PM, chia-yu.chang@nokia-bell-labs.com wrote: > From: Chia-Yu Chang > > This patch replaces existing min_tso_segs() with tso_segs() CC callback > for CC algorithm to provide explicit tso segment number of each data > burst and overrides tcp_tso_autosize(). > > This change provides below impacts on BPF struct_ops users: > - The callback is renamed from min_tso_segs() to tso_segs() > - The signature gains an extra u32 mss_now argument > - The return value semantics is changed from "floor value passed into > tcp_tso_autosize()" to "final tso_segs value", bypassing autosizing > > As a result, BPF programs shall be updated, because returning a small > constant will now directly limit the final tso_segs value instead of > specifying the minimum value passed to tcp_tso_autosize(). > > Signed-off-by: Ilpo Järvinen > Signed-off-by: Chia-Yu Chang > Reviewed-by: Emil Tsalapatis Sashiko nipa has more feedback, that looks relevant to me even if it's tagged not hi prio: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260730114919.658373-1-chia-yu.chang%40nokia-bell-labs.com /P