From: Kui-Feng Lee <sinquersw@gmail.com>
To: Quentin Monnet <qmo@kernel.org>,
Kui-Feng Lee <thinker.li@gmail.com>,
bpf@vger.kernel.org, ast@kernel.org, martin.lau@linux.dev,
song@kernel.org, kernel-team@meta.com, andrii@kernel.org
Cc: kuifeng@meta.com
Subject: Re: [PATCH bpf-next v5 8/8] bpftool: Fix pid_iter.bpf.c to comply with the change of bpf_link_fops.
Date: Fri, 24 May 2024 09:58:53 -0700 [thread overview]
Message-ID: <3b04c9bf-d320-4094-8e64-8fe40d6479a9@gmail.com> (raw)
In-Reply-To: <a69b12ef-4ff9-482a-8039-0f977ccaae2d@kernel.org>
On 5/24/24 09:20, Quentin Monnet wrote:
> 2024-05-24 00:09 UTC+0100 ~ Kui-Feng Lee <thinker.li@gmail.com>
>> To support epoll, a new instance of file_operations, bpf_link_fops_poll,
>> has been added for links that support epoll. The pid_iter.bpf.c checks
>> f_ops for links and other BPF objects. The check should fail for struct_ops
>> links without this patch.
>>
>> Cc: Quentin Monnet <qmo@kernel.org>
>> Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
>
> The bpftool change looks OK to me, thanks!
> Although I wouldn't call it a "fix" (in the commit object).
Got it! I would love to change it.
>
> Acked-by: Quentin Monnet <qmo@kernel.org>
Thank you for the review.
prev parent reply other threads:[~2024-05-24 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 23:08 [PATCH bpf-next v5 0/8] Notify user space when a struct_ops object is detached/unregistered Kui-Feng Lee
2024-05-23 23:08 ` [PATCH bpf-next v5 1/8] bpf: pass bpf_struct_ops_link to callbacks in bpf_struct_ops Kui-Feng Lee
2024-05-23 23:08 ` [PATCH bpf-next v5 2/8] bpf: enable detaching links of struct_ops objects Kui-Feng Lee
2024-05-23 23:08 ` [PATCH bpf-next v5 3/8] bpf: support epoll from bpf struct_ops links Kui-Feng Lee
2024-05-23 23:08 ` [PATCH bpf-next v5 4/8] bpf: export bpf_link_inc_not_zero Kui-Feng Lee
2024-05-23 23:08 ` [PATCH bpf-next v5 5/8] selftests/bpf: test struct_ops with epoll Kui-Feng Lee
2024-05-23 23:08 ` [PATCH bpf-next v5 6/8] selftests/bpf: detach a struct_ops link from the subsystem managing it Kui-Feng Lee
2024-05-23 23:08 ` [PATCH bpf-next v5 7/8] selftests/bpf: make sure bpf_testmod handling racing link destroying well Kui-Feng Lee
2024-05-23 23:08 ` [PATCH bpf-next v5 8/8] bpftool: Fix pid_iter.bpf.c to comply with the change of bpf_link_fops Kui-Feng Lee
2024-05-24 16:20 ` Quentin Monnet
2024-05-24 16:58 ` Kui-Feng Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b04c9bf-d320-4094-8e64-8fe40d6479a9@gmail.com \
--to=sinquersw@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=qmo@kernel.org \
--cc=song@kernel.org \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox