From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Edward Adam Davis <eadavis@qq.com>,
syzbot+cc32304f6487ebff9b70@syzkaller.appspotmail.com,
andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
daniel@iogearbox.net, haoluo@google.com,
john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org,
linux-kernel@vger.kernel.org, martin.lau@linux.dev,
netdev@vger.kernel.org, sdf@google.com, song@kernel.org,
syzkaller-bugs@googlegroups.com, yonghong.song@linux.dev
Subject: Re: [PATCH bpf-next] bpf: fix oob in btf_name_valid_section
Date: Mon, 11 Mar 2024 20:28:52 +0200 [thread overview]
Message-ID: <3b618a33551a0fe0ef5d74b9dc5399afca52209c.camel@gmail.com> (raw)
In-Reply-To: <CAEf4BzbbvBEwy6_S1MRjiGWWfS_nxy6qNsEc0_Jdro1c10b8Vw@mail.gmail.com>
On Mon, 2024-03-11 at 11:01 -0700, Andrii Nakryiko wrote:
[...]
> Eduard, I'd also say we should make __btf_name_valid() a bit more
> uniform by dropping that first if and then doing
>
> if (!__btf_name_char_ok(*src, src == src_orig))
> return false;
>
> where we just remember original string pointer in src_orig.
>
> WDYT?
Agree, this looks simpler.
prev parent reply other threads:[~2024-03-11 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 8:55 [syzbot] [bpf?] KASAN: slab-out-of-bounds Read in btf_datasec_check_meta syzbot
2024-03-11 13:16 ` [PATCH bpf-next] bpf: fix oob in btf_name_valid_section Edward Adam Davis
2024-03-11 14:48 ` Eduard Zingerman
2024-03-11 18:01 ` Andrii Nakryiko
2024-03-11 18:28 ` Eduard Zingerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b618a33551a0fe0ef5d74b9dc5399afca52209c.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eadavis@qq.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=syzbot+cc32304f6487ebff9b70@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox