From: Yonghong Song <yonghong.song@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>, bpf@vger.kernel.org
Cc: Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Eduard Zingerman <eddyz87@gmail.com>,
kernel-team@fb.com
Subject: Re: [PATCH bpf-next v3 00/11] bpf: Follow up by-value struct and __int128 argument support
Date: Fri, 16 Oct 2026 09:56:39 -0700 [thread overview]
Message-ID: <3bf3d88d-bc40-40d8-a8ef-5d139aa38318@linux.dev> (raw)
In-Reply-To: <DM6EOZ20E9ON.3KR4R7QU4SOJR@gmail.com>
On 10/16/26 9:34 AM, Alexei Starovoitov wrote:
> On Fri, Oct 16, 2026 at 09:22 AM Yonghong Song <yonghong.song@linux.dev> wrote:
>> This one can exercise for s390x, x86_64 and arm64. Do you think it is worthwhile?
> ohh. makes sense then.
> Patch 4 fixes s390 too. Without it s390 trampoline sees arg_size 16
> for v, does mvc 16 bytes from 0(%r3) and restores r2-r4 only.
> callee_odd() will be the only test for that and CI runs s390x.
> Then LO/HI has a user in tracing_struct_int128_tracer.c. Keep it there
> and drop it from tracing_struct_int128.c.
I will use BPF_PROG2 macro which sounds better to have LO/HI thing.
See progs/tracing_struct.c.
>
>> Two other bpf functions, which has stack arguments, need rejection with
>> ... && !defined(__TARGET_ARCH_s390)
> Same #if as in progs/stack_arg.c ?
>
> If it turns out to be more than that it can be a follow up too.
I will do a follow-up for this since I didn't test riscv yet.
prev parent reply other threads:[~2026-10-16 16:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 17:09 [PATCH bpf-next v3 00/11] bpf: Follow up by-value struct and __int128 argument support Yonghong Song
2026-10-13 17:09 ` [PATCH bpf-next v3 01/11] bpf, x86: Pass a trampoline's stack arguments by the calling convention Yonghong Song
2026-10-13 17:09 ` [PATCH bpf-next v3 02/11] selftests/bpf: Test trampoline stack args in a program that can tail call Yonghong Song
2026-10-13 17:09 ` [PATCH bpf-next v3 03/11] selftests/bpf: Test by-value __int128 kfunc arguments at an odd slot Yonghong Song
2026-10-13 17:09 ` [PATCH bpf-next v3 04/11] bpf: Describe a BPF function to its trampoline as one u64 per slot Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 05/11] bpf, x86: Place trampoline arguments by the x86-64 calling convention Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 06/11] selftests/bpf: Test trampoline args around a 16-byte aligned stack arg Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 07/11] selftests/bpf: Test trampoline args of a BPF function at an odd slot Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 08/11] bpf: Refuse a trampoline on an unreliable static function with stack args Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 09/11] selftests/bpf: Test trampolines on more BPF functions " Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 10/11] bpf, x86: Give a kfunc's stack argument the 16-byte alignment it needs Yonghong Song
2026-10-16 2:46 ` Alexei Starovoitov
2026-10-16 15:45 ` Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 11/11] selftests/bpf: Test that a kfunc gets its __int128 stack argument aligned Yonghong Song
2026-10-16 2:48 ` [PATCH bpf-next v3 00/11] bpf: Follow up by-value struct and __int128 argument support Alexei Starovoitov
2026-10-16 15:50 ` Yonghong Song
2026-10-16 16:00 ` Alexei Starovoitov
2026-10-16 16:22 ` Yonghong Song
2026-10-16 16:34 ` Alexei Starovoitov
2026-10-16 16:56 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bf3d88d-bc40-40d8-a8ef-5d139aa38318@linux.dev \
--to=yonghong.song@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox