From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org
Cc: kernel-team@meta.com
Subject: Re: [PATCH v2 bpf 1/5] libbpf: feature-detect arg:ctx tag support in kernel
Date: Thu, 18 Jan 2024 21:50:04 +0200 [thread overview]
Message-ID: <3cb503acbd2d65dc08172d620fe5dfff5f51be0d.camel@gmail.com> (raw)
In-Reply-To: <20240117223340.1733595-2-andrii@kernel.org>
On Wed, 2024-01-17 at 14:33 -0800, Andrii Nakryiko wrote:
[...]
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index c5a42ac309fd..61db92189517 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -6757,6 +6757,69 @@ static int clone_func_btf_info(struct btf *btf, int orig_fn_id, struct bpf_progr
> return fn_id;
> }
>
> +static int probe_kern_arg_ctx_tag(void)
[...]
> + btf_fd = libbpf__load_raw_btf((char *)types, sizeof(types), strs, sizeof(strs));
> + if (btf_fd < 0)
> + return 0;
Question:
suppose this is an old kernel and decl tags are not supported,
should negative result be cached as 0 in such case?
[...]
next prev parent reply other threads:[~2024-01-18 19:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 22:33 [PATCH v2 bpf 0/5] Tighten up arg:ctx type enforcement Andrii Nakryiko
2024-01-17 22:33 ` [PATCH v2 bpf 1/5] libbpf: feature-detect arg:ctx tag support in kernel Andrii Nakryiko
2024-01-18 19:50 ` Eduard Zingerman [this message]
2024-01-19 0:43 ` Andrii Nakryiko
2024-01-19 0:46 ` Eduard Zingerman
2024-01-17 22:33 ` [PATCH v2 bpf 2/5] bpf: extract bpf_ctx_convert_map logic and make it more reusable Andrii Nakryiko
2024-01-17 22:33 ` [PATCH v2 bpf 3/5] bpf: enforce types for __arg_ctx-tagged arguments in global subprogs Andrii Nakryiko
2024-01-18 19:50 ` Eduard Zingerman
2024-01-19 0:50 ` Andrii Nakryiko
2024-01-17 22:33 ` [PATCH v2 bpf 4/5] selftests/bpf: add tests confirming type logic in kernel for __arg_ctx Andrii Nakryiko
2024-01-17 22:33 ` [PATCH v2 bpf 5/5] libbpf: warn on unexpected __arg_ctx type when rewriting BTF Andrii Nakryiko
2024-01-18 19:50 ` Eduard Zingerman
2024-01-19 0:53 ` Andrii Nakryiko
2024-01-19 1:00 ` Eduard Zingerman
2024-01-18 19:49 ` [PATCH v2 bpf 0/5] Tighten up arg:ctx type enforcement Eduard Zingerman
2024-01-18 19:53 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cb503acbd2d65dc08172d620fe5dfff5f51be0d.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox