From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<magnus.karlsson@intel.com>, <alasdair.mcwilliam@outlook.com>
Subject: Re: [PATCH v2 intel-net 1/2] ice: xsk: change batched Tx descriptor cleaning
Date: Wed, 31 Aug 2022 13:14:08 -0700 [thread overview]
Message-ID: <3e559af7-bc84-95fb-7cea-224b7a3da0e2@intel.com> (raw)
In-Reply-To: <20220830125122.9665-2-maciej.fijalkowski@intel.com>
On 8/30/2022 5:51 AM, Maciej Fijalkowski wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.h b/drivers/net/ethernet/intel/ice/ice_xsk.h
> index 21faec8e97db..35dd3c57c4df 100644
> --- a/drivers/net/ethernet/intel/ice/ice_xsk.h
> +++ b/drivers/net/ethernet/intel/ice/ice_xsk.h
> @@ -26,12 +26,9 @@ bool ice_alloc_rx_bufs_zc(struct ice_rx_ring *rx_ring, u16 count);
> bool ice_xsk_any_rx_ring_ena(struct ice_vsi *vsi);
> void ice_xsk_clean_rx_ring(struct ice_rx_ring *rx_ring);
> void ice_xsk_clean_xdp_ring(struct ice_tx_ring *xdp_ring);
> -bool ice_xmit_zc(struct ice_tx_ring *xdp_ring, u32 budget, int napi_budget);
> +bool ice_xmit_zc(struct ice_tx_ring *xdp_ring);
> #else
> -static inline bool
Looks like this shouldn't be deleted.
> -ice_xmit_zc(struct ice_tx_ring __always_unused *xdp_ring,
> - u32 __always_unused budget,
> - int __always_unused napi_budget)
> +ice_xmit_zc(struct ice_tx_ring __always_unused *xdp_ring)
> {
> return false;
> }
next prev parent reply other threads:[~2022-08-31 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 12:51 [PATCH v2 intel-net 0/2] ice: xsk: ZC changes Maciej Fijalkowski
2022-08-30 12:51 ` [PATCH v2 intel-net 1/2] ice: xsk: change batched Tx descriptor cleaning Maciej Fijalkowski
2022-08-31 20:14 ` Tony Nguyen [this message]
2022-08-30 12:51 ` [PATCH v2 intel-net 2/2] ice: xsk: drop power of 2 ring size restriction for AF_XDP Maciej Fijalkowski
2022-08-31 20:11 ` [PATCH v2 intel-net 0/2] ice: xsk: ZC changes Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e559af7-bc84-95fb-7cea-224b7a3da0e2@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=alasdair.mcwilliam@outlook.com \
--cc=bpf@vger.kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox