From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76EE32BB13 for ; Thu, 23 Jul 2026 00:57:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784768243; cv=none; b=SghSzEZe9b6yJv9lP7QsntqfSWqmkz/VFxiskuDGjj8zPrVO40YQdspncCMgrnWQ0g54bX6p5cuqE+K62D6gIuQY3vkP2krdD5TOIlpFlVBAi+3kToqgqczP8//kRWBWBqL8YujLevug3GKsXCue3en2OTg6cietvTfgWTQDY60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784768243; c=relaxed/simple; bh=TZeOAZ7BwYGXh2zsl7sZ41S13a6q0ZHTmJzskF3jVc4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J0OPzDyohcp2fhpQoZhBuh2iNxUpEjCZw6rlv6K0I7X8JOpxD1Iyu8xmy8uIG7/SanAsRmcTTTgXaF1tdiszXnM9Jnlr3aAANvPPVMTEpYBjxYqqqnNO9Ois/lgQqldlQbDqXcEH7okEPKrI4rAgI27rZ0pwDg94KqBxARpuPNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=bat6XUpG; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="bat6XUpG" Message-ID: <3e55f385-e475-4b5e-addd-836c52592b59@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784768239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PIfkFbWZxgkbGSlk+KJfGn5G3GfZLNf8U+HUZilJ53M=; b=bat6XUpGLLZktwrlM+BsluCiqRzKcGREbiMGmg8LCf23Ey0efFKvHUN+81cdszEX/tYPFH zONO/SXIKZkgEGgRb3D4OTvue0Cjsml5Leu4LFIBNcZ8cYQ3HPP3RC+MZ5MtLh6gXqo4y1 wWyHCJ/4Myo155FRZClEet/eUi35WGA= Date: Wed, 22 Jul 2026 17:57:10 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v1 7/8] resolve_btfids: Discover kfuncs from BTF ID sets To: bot+bpf-ci@kernel.org, ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net, eddyz87@gmail.com, memxor@gmail.com Cc: bentiss@kernel.org, jikos@kernel.org, emil@etsalapatis.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-input@vger.kernel.org, kernel-team@meta.com, martin.lau@kernel.org, yonghong.song@linux.dev, clm@meta.com References: <20260722233518.778854-8-ihor.solodrai@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ihor Solodrai In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 7/22/26 5:32 PM, bot+bpf-ci@kernel.org wrote: >> collect_kfuncs() currently uses bpf_kfunc decl tags to identify the >> list of kfuncs. The decl tags are generated by pahole, which makes >> current implementation implicitly rely on those tags being generated. >> >> The authoritative source, used by the the BPF verifier for kfunc >> registration, of functions being BPF kfuncs are >> BTF_KFUNCS_START()/END() declarations. These are BTF_ID_SET8 under the >> hood. Currently resolve_btfids reads kfunc flags from these sets, and >> populates them with BTF IDs. >> >> Implement kfunc discovery from BTF_ID_SET8 symbols in resolve_btfids, >> removing the dependency on pahole's emmission of decl tags. >> >> Walk BTF_ID_KIND_SET8 sets, and use the address-to-symbol index to >> look up set entry's BTF_ID symbol name (before .BTF_ids is patched), >> recording the paired flags directly. This makes find_kfunc_flags() >> helper unnecessary, so it's removed. >> >> Signed-off-by: Ihor Solodrai > > This isn't a bug, but there are a couple of small typos in the > changelog: "used by the the BPF verifier" has a duplicated "the", and > "pahole's emmission of decl tags" should be "emission". I guess typos don't count as proof-of-human-typing, because AI can be instructed to make typos :) Will fix. > > > --- > AI reviewed your patch. Please fix the bug or email reply why it's not a bug. > See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md > > CI run summary: https://github.com/kernel-patches/bpf/actions/runs/29967476366