From: Martin KaFai Lau <martin.lau@linux.dev>
To: Ming Lei <ming.lei@redhat.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, song@kernel.org,
andrii@kernel.org, drosen@google.com, kuifeng@meta.com,
sinquersw@gmail.com, thinker.li@gmail.com,
Yonghong Song <yonghong.song@linux.dev>,
Benjamin Tissoires <bentiss@kernel.org>,
Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH V2 bpf-next] bpf: export btf_find_by_name_kind and bpf_base_func_proto
Date: Wed, 31 Jul 2024 17:34:37 -0700 [thread overview]
Message-ID: <40851e4c-3a20-4a3d-a992-d00337f5d29f@linux.dev> (raw)
In-Reply-To: <CAFj5m9KvXQa8VOJ_K2ZF0V2J2-wiwaJb4Df7dzE3ZC3jAGOg8g@mail.gmail.com>
On 7/31/24 1:18 AM, Ming Lei wrote:
> On Tue, Jul 30, 2024 at 5:07 AM Martin KaFai Lau <martin.lau@linux.dev> wrote:
>>
>> On 7/26/24 5:59 AM, Ming Lei wrote:
>>> Almost all existed struct_ops users(hid, sched_ext, ...) need the two APIs.
>>>
>>> In-tree hid-bpf code(drivers/hid/bpf/hid_bpf_struct_ops.c) can't be built
>>> as module because the two APIs aren't exported.
>>
>> The patch looks fine. I don't see "config HID_BPF" can be built as a module now
>> though that could expose this issue. Did I miss something?
>
> Yeah, this patch doesn't try to change HID_BPF yet, and it can be thought
> as one struct_ops module prep patch.
>
> The issue itself is observed when I write ublk-bpf since ublk is one module
> and struct_ops is allowed to be registered in the module.
Good to hear struct_ops find another potential use case. The ublk-bpf
development cannot continue without building as kmod?
Instead of exporting it now and pending without a user, I will wait till the
first in-tree kmod use case comes up first.
prev parent reply other threads:[~2024-08-01 0:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 12:59 [PATCH V2 bpf-next] bpf: export btf_find_by_name_kind and bpf_base_func_proto Ming Lei
2024-07-26 14:26 ` Yonghong Song
2024-07-26 16:06 ` Kui-Feng Lee
2024-07-29 21:07 ` Martin KaFai Lau
2024-07-31 8:18 ` Ming Lei
2024-08-01 0:34 ` Martin KaFai Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40851e4c-3a20-4a3d-a992-d00337f5d29f@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bentiss@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=drosen@google.com \
--cc=jikos@kernel.org \
--cc=kuifeng@meta.com \
--cc=ming.lei@redhat.com \
--cc=sinquersw@gmail.com \
--cc=song@kernel.org \
--cc=thinker.li@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox