BPF List
 help / color / mirror / Atom feed
From: Matthias Schwarzott <zzam@gentoo.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, dwarves@vger.kernel.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	bpf@vger.kernel.org, Alan Maguire <alan.maguire@oracle.com>,
	Jiri Olsa <jolsa@kernel.org>, Jan Engelhardt <jengelh@inai.de>,
	Viktor Malik <vmalik@redhat.com>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Jan Alexander Steffens <heftig@archlinux.org>,
	Domenico Andreoli <cavok@debian.org>,
	Dominique Leuenberger <dimstar@opensuse.org>,
	Daniel Xu <dxu@dxuuu.xyz>,
	Yonghong Song <yonghong.song@linux.dev>
Subject: Re: ANNOUNCE: pahole v1.27 (reproducible builds, BTF kfuncs)
Date: Wed, 12 Jun 2024 12:07:09 +0200	[thread overview]
Message-ID: <4154d202-5c72-493e-bf3f-bce882a296c6@gentoo.org> (raw)
In-Reply-To: <ZmjBHWw-Q5hKBiwA@x1>

Am 11.06.24 um 23:26 schrieb Arnaldo Carvalho de Melo:
> Hi,
>   
> 	The v1.27 release of pahole and its friends is out, supporting
> parallel reproducible builds and encoding kernel kfuncs in BTF, allowing
> tools such as bpftrace to enumerate the available kfuncs and obtain its
> function signatures and return types.
> 

Regarding packaging of pahole:
What is the state of the contained ostra-cg?
I have no clue what it is and how to use it. Is there still a use-case 
for it?

Starting it without arguments only shows the usage string.
Running it with two dummy arguments:
$ ostra-cg x y
Traceback (most recent call last):
   File "/usr/bin/ostra-cg", line 404, in <module>
     class_def = ostra.class_definition(class_def_file = "%s.fields" % 
traced_class,
 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/share/dwarves/runtime/python/ostra.py", line 154, in __init__
     f = file(class_def_file)
         ^^^^
NameError: name 'file' is not defined. Did you mean: 'field'?

According to 
https://stackoverflow.com/questions/32131230/python-file-function the 
function file() does not exist in python3.

This part could be fixed by replacing it with open() but I wonder if 
this is worth it.

As nobody has complained about it being broken:
Should ostra just be removed?

Regards
Matthias


  parent reply	other threads:[~2024-06-12 10:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 21:26 ANNOUNCE: pahole v1.27 (reproducible builds, BTF kfuncs) Arnaldo Carvalho de Melo
2024-06-11 21:38 ` Dominique Martinet
2024-06-11 22:52   ` Arnaldo Carvalho de Melo
2024-06-11 23:46     ` Dominique Martinet
2024-06-12 10:07 ` Matthias Schwarzott [this message]
2024-06-14 19:09   ` Arnaldo Carvalho de Melo
2024-06-13 21:40 ` Nathan Chancellor
2024-06-17 19:39   ` Arnaldo Carvalho de Melo
2024-06-17 20:02     ` [PATCH/RFT] " Arnaldo Carvalho de Melo
2024-06-17 21:08       ` Nathan Chancellor
2024-06-18 13:51         ` Arnaldo Carvalho de Melo
2024-06-18 14:30           ` [PATCH fyi 1/1] dwarf_loader: Add missing cus__add(cus, cu) to cus__merge_and_process_cu() Arnaldo Carvalho de Melo
2024-07-10 19:31           ` [PATCH/RFT] Re: ANNOUNCE: pahole v1.27 (reproducible builds, BTF kfuncs) Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4154d202-5c72-493e-bf3f-bce882a296c6@gentoo.org \
    --to=zzam@gentoo.org \
    --cc=acme@kernel.org \
    --cc=alan.maguire@oracle.com \
    --cc=bpf@vger.kernel.org \
    --cc=cavok@debian.org \
    --cc=dimstar@opensuse.org \
    --cc=dwarves@vger.kernel.org \
    --cc=dxu@dxuuu.xyz \
    --cc=eddyz87@gmail.com \
    --cc=heftig@archlinux.org \
    --cc=jengelh@inai.de \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vmalik@redhat.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox