BPF List
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@meta.com>
To: Domenico Cerasuolo <cerasuolodomenico@gmail.com>,
	bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
	daniel@iogearbox.net, kafai@fb.com, kernel-team@fb.com
Subject: Re: [PATCH bpf-next v2] selftests: fix test group SKIPPED result
Date: Wed, 9 Nov 2022 13:11:34 -0800	[thread overview]
Message-ID: <45abee73-850d-9563-2d70-46aec79cb054@meta.com> (raw)
In-Reply-To: <20221109184039.3514033-1-cerasuolodomenico@gmail.com>



On 11/9/22 10:40 AM, Domenico Cerasuolo wrote:
> From: Domenico Cerasuolo <dceras@meta.com>
> 
> When showing the result of a test group, if one
> of the subtests was skipped, while still having
> passing subtests, the group result was marked as
> SKIP. E.g.:
> 
> 223/1   usdt/basic:SKIP
> 223/2   usdt/multispec:OK
> 223/3   usdt/urand_auto_attach:OK
> 223/4   usdt/urand_pid_attach:OK
> 223     usdt:SKIP
> 
> The test result of usdt in the example above
> should be OK instead of SKIP, because the test
> group did have passing tests and it would be
> considered in "normal" state.
> 
> With this change, only if all of the subtests
> were skipped, the group test is marked as SKIP.
> When only some of the subtests are skipped, a
> more detailed result is given, stating how
> many of the subtests were skipped. E.g:
> 
> 223/1   usdt/basic:SKIP
> 223/2   usdt/multispec:OK
> 223/3   usdt/urand_auto_attach:OK
> 223/4   usdt/urand_pid_attach:OK
> 223     usdt:OK (SKIP: 1/4)
> 
> changes from v1:
> - added (SKIP: x/y) to OK tests that have
> SKIP subtests
> - merged print_test_name and test_result
> functions as they were always called together
> 
> Signed-off-by: Domenico Cerasuolo <dceras@meta.com>

Acked-by: Yonghong Song <yhs@fb.com>

  reply	other threads:[~2022-11-09 21:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 18:40 [PATCH bpf-next v2] selftests: fix test group SKIPPED result Domenico Cerasuolo
2022-11-09 21:11 ` Yonghong Song [this message]
2022-11-10 17:02   ` John Fastabend
2022-11-10  5:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45abee73-850d-9563-2d70-46aec79cb054@meta.com \
    --to=yhs@meta.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=cerasuolodomenico@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=kafai@fb.com \
    --cc=kernel-team@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox