Re: [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory

Jesper Dangaard Brouer
2020-04-27T15:49:16Z

On Mon, 27 Apr 2020 16:02:40 +0200
Jesper Dangaard Brouer <brouer@redhat.com> wrote:

> On Mon, 27 Apr 2020 15:29:40 +0200
> Veronika Kabatova <vkabatov@redhat.com> wrote:
>
> > $(OUTPUT)/runqslower makefile target doesn't actually create runqslower
> > binary in the $(OUTPUT) directory. As lib.mk expects all
> > TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in
> > the OUTPUT directory, this results in an error when running e.g. `make
> > install`:
> >
> > rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No
> > such file or directory (2)
> >
> > Copy the binary into the OUTPUT directory after building it to fix the
> > error.
> >
> > Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
> > ---
>
> Looks good to me
>
> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>

Let us add a Fixes tag (patchwork should pick this up).

Fixes: 3a0d3092a4ed ("selftests/bpf: Build runqslower from selftests")

--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer