From: Eduard Zingerman <eddyz87@gmail.com>
To: Yang Li <yang.lee@linux.alibaba.com>,
ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,
andrii@kernel.org, martin.lau@linux.dev
Cc: kpsingh@kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] bpf: remove unused function
Date: Tue, 12 Dec 2023 19:02:17 +0200 [thread overview]
Message-ID: <478ebb094a7f306f49db334bcece2e0d87524f77.camel@gmail.com> (raw)
In-Reply-To: <20231212005436.103829-1-yang.lee@linux.alibaba.com>
On Tue, 2023-12-12 at 08:54 +0800, Yang Li wrote:
> The function are defined in the verifier.c file, but not called
> elsewhere, so delete the unused function.
>
> kernel/bpf/verifier.c:3448:20: warning: unused function 'bt_set_slot'
> kernel/bpf/verifier.c:3453:20: warning: unused function 'bt_clear_slot'
> kernel/bpf/verifier.c:3488:20: warning: unused function 'bt_is_slot_set'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7714
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
These are unused indeed.
Looks like calls to these functions were removed in commit:
41f6f64e6999 ("bpf: support non-r10 register spill/fill to/from stack in precision tracking")
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
next prev parent reply other threads:[~2023-12-12 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 0:54 [PATCH -next] bpf: remove unused function Yang Li
2023-12-12 17:02 ` Eduard Zingerman [this message]
2023-12-12 18:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478ebb094a7f306f49db334bcece2e0d87524f77.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=abaci@linux.alibaba.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox