BPF List
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: Andrii Nakryiko <andrii@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	 Mykola Lysenko <mykolal@fb.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>,  Shuah Khan <shuah@kernel.org>
Cc: Geliang Tang <tanggeliang@kylinos.cn>,
	bpf@vger.kernel.org,  linux-kselftest@vger.kernel.org
Subject: Re: [PATCH mptcp-next v3 0/6] use network helpers, part 7
Date: Mon, 17 Jun 2024 17:17:20 +0800	[thread overview]
Message-ID: <47a472d1ff1e9ec37b71d371cbc00395811f56c0.camel@kernel.org> (raw)
In-Reply-To: <cover.1718612857.git.tanggeliang@kylinos.cn>

Sorry, v3 breaks the CI.
Changes Requested.

-Geliang

On Mon, 2024-06-17 at 16:33 +0800, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v3:
>  - rename start_client to client_socket
>  - Use connect_to_addr in connect_to_fd_opt
> 
> v2:
>  - update patch 2, extract a new helper start_client.
>  - drop patch 3, keep must_fail in network_helper_opts.
> 
> Drop type and noconnect from network_helper_opts. And use
> start_server_str
> in mptcp and test_tcp_check_syncookie_user.
> 
> Patches 1-4 address Martin's comments in the previous series.
> 
> Geliang Tang (6):
>   selftests/bpf: Drop type from network_helper_opts
>   selftests/bpf: Use connect_to_addr in connect_to_fd_opt
>   selftests/bpf: Add client_socket helper
>   selftests/bpf: Drop noconnect from network_helper_opts
>   selftests/bpf: Use start_server_str in mptcp
>   selftests/bpf: Use start_server_str in
> test_tcp_check_syncookie_user
> 
>  tools/testing/selftests/bpf/network_helpers.c | 100 ++++++++--------
> --
>  tools/testing/selftests/bpf/network_helpers.h |   6 +-
>  .../selftests/bpf/prog_tests/bpf_tcp_ca.c     |   2 +-
>  .../selftests/bpf/prog_tests/cgroup_v1v2.c    |   4 +-
>  .../bpf/prog_tests/ip_check_defrag.c          |  10 +-
>  .../testing/selftests/bpf/prog_tests/mptcp.c  |   7 +-
>  .../bpf/test_tcp_check_syncookie_user.c       |  29 +----
>  7 files changed, 56 insertions(+), 102 deletions(-)
> 


      parent reply	other threads:[~2024-06-17  9:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17  8:33 [PATCH mptcp-next v3 0/6] use network helpers, part 7 Geliang Tang
2024-06-17  8:33 ` [PATCH mptcp-next v3 1/6] selftests/bpf: Drop type from network_helper_opts Geliang Tang
2024-06-17  8:33 ` [PATCH mptcp-next v3 2/6] selftests/bpf: Use connect_to_addr in connect_to_fd_opt Geliang Tang
2024-06-17  8:33 ` [PATCH mptcp-next v3 3/6] selftests/bpf: Add client_socket helper Geliang Tang
2024-06-17  8:33 ` [PATCH mptcp-next v3 4/6] selftests/bpf: Drop noconnect from network_helper_opts Geliang Tang
2024-06-17  8:33 ` [PATCH mptcp-next v3 5/6] selftests/bpf: Use start_server_str in mptcp Geliang Tang
2024-06-17  8:33 ` [PATCH mptcp-next v3 6/6] selftests/bpf: Use start_server_str in test_tcp_check_syncookie_user Geliang Tang
2024-06-17  9:17 ` Geliang Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47a472d1ff1e9ec37b71d371cbc00395811f56c0.camel@kernel.org \
    --to=geliang@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=sdf@google.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=tanggeliang@kylinos.cn \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox