BPF List
 help / color / mirror / Atom feed
From: Sahil <icegambit91@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	Quentin Monnet <quentin@isovalent.com>
Cc: martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
	yonghong.song@linux.dev, john.fastabend@gmail.com,
	kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
	jolsa@kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpftool: Mount bpffs on provided dir instead of parent dir
Date: Fri, 08 Mar 2024 01:42:15 +0530	[thread overview]
Message-ID: <4911236.31r3eYUQgx@valdaarhun> (raw)
In-Reply-To: <2f65b98c-a442-4316-884c-a877233edc60@isovalent.com>

Hi,

On Tuesday, March 5, 2024 4:05:32 PM IST Quentin Monnet wrote:
> [...]
> Yes, we should remove this second condition too for files. Running
> "is_bpffs(name)" makes no sense as we know we'll have an error at this
> point.
> 
> What we could do to improve the current code, however, is returning an
> error from mount_bpffs_for_pin() if the file exists, rather than
> mounting the bpffs and waiting for bpf_obj_pin() to return the error.
> This would prevent bpftool from mounting the bpffs when we already know
> the operation will fail.
> 
> Quentin

Sorry for the delay in replying. I have got a patch ready and have
incorporated this as well. I need to run a few tests and then I'll be
able to send a new patch.

Thanks,
Sahil



      reply	other threads:[~2024-03-07 20:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29 13:05 [PATCH bpf-next] bpftool: Mount bpffs on provided dir instead of parent dir Sahil Siddiq
2024-02-29 14:59 ` Quentin Monnet
2024-02-29 19:50   ` Sahil
2024-03-01 20:28   ` Sahil
2024-03-04 13:50     ` Quentin Monnet
2024-03-04 20:34       ` Sahil
2024-03-05 10:35         ` Quentin Monnet
2024-03-07 20:12           ` Sahil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4911236.31r3eYUQgx@valdaarhun \
    --to=icegambit91@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=quentin@isovalent.com \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox