From: Sahil <icegambit91@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
Quentin Monnet <qmo@kernel.org>
Cc: martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v3] bpftool: Mount bpffs on provided dir instead of parent dir
Date: Mon, 01 Apr 2024 09:57:38 +0530 [thread overview]
Message-ID: <4913334.31r3eYUQgx@valdaarhun> (raw)
In-Reply-To: <dfcab867-0b5d-4d3c-aeb0-43633b571196@kernel.org>
Hi,
Thank you for the review. I have refactored the error messages. I have
removed a few more parantheses.
On Wednesday, March 27, 2024 6:44:52 AM IST Quentin Monnet wrote:
> [...]
> We're already on an error path, I'd maybe drop the check on the return
> value from rmdir(). It doesn't matter much if it fails, I think.
I was thinking that if we fail to mount but manage to create the dir
successfully, then we should also clean up that new dir and send a
notification if we fail to remove that dir so the user can manually
remove it.
I guess it's ok to remove that error message though since dealing with
the "fail to mount" error will anyway require manual intervention.
> [...]
> This function must be renamed, as you did at the call sites.
Sorry, I must have forgotten to copy this when copying the changes
from the bpftool repo to my local bpf-next tree.
Thanks,
Sahil
prev parent reply other threads:[~2024-04-01 4:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 19:19 [PATCH bpf-next v3] bpftool: Mount bpffs on provided dir instead of parent dir Sahil Siddiq
2024-03-27 1:14 ` Quentin Monnet
2024-04-01 4:27 ` Sahil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4913334.31r3eYUQgx@valdaarhun \
--to=icegambit91@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=qmo@kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox