From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (mta1.migadu.com [37.59.57.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25B1429D26C for ; Wed, 12 Aug 2026 04:03:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=37.59.57.117 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786507392; cv=none; b=tVjBk6+7UuTaOyy3CuVbYnsmz4+XzTXr9iTeH0e/6Ry/y6Any5lWctiYxdoaASpeESB6bNekhB1g9y2LvgAHacBB29bKxYVVhRUZneCFOqA4N1pY0eXAz/1AtjCqnCv0tXiUINXv7KGHGzPq6mK2TUASKia/RoB6g5geL90oNIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786507392; c=relaxed/simple; bh=eqQL7PzRmYFlQnSqgkhleoEEpCE3AJFyzddDt9bakaI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qzbn6fEr5AWewlT5bR1Lb9yK0UXv8hjEBTRxQHq/KGlZXOMzg5kAciOlmkUTCHdKuTeWXFT7AIi10MiglX8VORoTx8sEM3+1+bjXjWt/OCYGIel6xcfMEySaZt0hRHT8FjiZz2sHy1p68H4B2a1HxdheimZYltxMRXTjvm/UTM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=PzvQ2jUE; arc=none smtp.client-ip=37.59.57.117 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="PzvQ2jUE" Message-ID: <4cbf31a2-c3ec-459a-a0b7-5a5f6e9c5fce@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786507385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jl8RugOlQzZny737vIz0A+aYF7ZRm3VJqbI6xEREGvU=; b=PzvQ2jUEXIP36fnXPTRT2aMBS4G8s3DkKt27WR+uCRNSg7AakYK5npSQrewGapFTEbml93 sg9c9oJywf8HvX6ZyyNBBEBwPvIbyG10MyTmu2OdZbrpQrFx2nwQ5FWSLH2SFdPT3P2Oar TB+ITubdNHIyz3tD+1lTJSX0NUJ9/Tk= Date: Wed, 12 Aug 2026 12:02:35 +0800 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next 02/13] bpf: Factor out update_fentry_multi helper To: sashiko-reviews@lists.linux.dev Cc: bpf@vger.kernel.org References: <20260809150111.45000-1-leon.hwang@linux.dev> <20260809150111.45000-3-leon.hwang@linux.dev> <20260809151433.627C21F000E9@smtp.kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Leon Hwang In-Reply-To: <20260809151433.627C21F000E9@smtp.kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 9/8/26 23:14, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] The `orig_flags` parameter in the new `update_fentry_multi` helper function is unused. > -- > > --- Patch [2]: [PATCH bpf-next 02/13] bpf: Factor out update_fentry_multi helper --- > commit c90e2dad924e48bb1043b67addb36ec916a663d1 > Author: Leon Hwang > > bpf: Factor out update_fentry_multi helper > > This commit factors out common functionality from the register, unregister, > and modify multi fentry callbacks into a new update_fentry_multi helper. > >> diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c >> index 8c2c1d1b90941..6e1898e1b200f 100644 >> --- a/kernel/bpf/trampoline.c >> +++ b/kernel/bpf/trampoline.c >> @@ -1568,47 +1568,41 @@ static void ftrace_hash_add(struct ftrace_hash *hash, struct ftrace_func_entry * >> add_ftrace_hash_entry(hash, entry); >> } >> >> -static int register_fentry_multi(struct bpf_trampoline *tr, struct bpf_tramp_image *im, void *ptr) >> +static int update_fentry_multi(struct bpf_trampoline *tr, u32 orig_flags, >> + struct bpf_tramp_image *im, struct ftrace_hash *hash, >> + struct bpf_tracing_multi_data *data) >> { > > [Severity: Low] > Is it intended to keep the orig_flags parameter here? It appears to be > completely unused in the body of this new helper function. > Yes, it was intended. However, will drop orig_flags when re-implementing tracing_multi link support for bpf progs with another code path. Thanks, Leon