From: "Ihor Solodrai" <ihor.solodrai@linux.dev>
To: "Alan Maguire" <alan.maguire@oracle.com>,
dwarves@vger.kernel.org, bpf@vger.kernel.org
Cc: acme@kernel.org, ast@kernel.org, andrii@kernel.org,
eddyz87@gmail.com, mykolal@fb.com, kernel-team@meta.com
Subject: Re: [PATCH dwarves 3/3] pahole: introduce --btf_feature=attributes
Date: Tue, 11 Feb 2025 00:16:26 +0000 [thread overview]
Message-ID: <4d7b119dc632e0b8ea4ed6da4a5b49b20a521676@linux.dev> (raw)
In-Reply-To: <a1b4d24b-9d7b-464c-8055-f8a270082e65@oracle.com>
On 2/10/25 2:13 PM, Alan Maguire wrote:
> On 07/02/2025 02:14, Ihor Solodrai wrote:
>> Add a feature flag "attributes" (default: false) controlling whether
>> pahole is allowed to generate BTF attributes: type tags and decl tags
>> with kind_flag = 1.
>>
>> This is necessary for backward compatibility, as BPF verifier does not
>> recognize tags with kind_flag = 1 prior to (at least) 6.14-rc1 [1].
>>
>> [1] https://lore.kernel.org/bpf/20250130201239.1429648-1-ihor.solodrai@linux.dev/
>>
>> Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
> Needs update to pahole man page describing the new "attributes"
> btf_feature, but aside from that LGTM.
I was wondering what have I missed. Thanks.
>
> Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
>
> [...]
prev parent reply other threads:[~2025-02-11 0:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 2:14 [PATCH dwarves 0/3] btf_encoder: emit type tags for bpf_arena pointers Ihor Solodrai
2025-02-07 2:14 ` [PATCH dwarves 1/3] btf_encoder: collect kfuncs info in btf_encoder__new Ihor Solodrai
2025-02-10 20:57 ` Eduard Zingerman
2025-02-10 22:42 ` Ihor Solodrai
2025-02-11 0:35 ` Eduard Zingerman
2025-02-07 2:14 ` [PATCH dwarves 2/3] btf_encoder: emit type tags for bpf_arena pointers Ihor Solodrai
2025-02-10 22:11 ` Alan Maguire
2025-02-11 0:11 ` Ihor Solodrai
2025-02-07 2:14 ` [PATCH dwarves 3/3] pahole: introduce --btf_feature=attributes Ihor Solodrai
2025-02-10 22:13 ` Alan Maguire
2025-02-11 0:16 ` Ihor Solodrai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d7b119dc632e0b8ea4ed6da4a5b49b20a521676@linux.dev \
--to=ihor.solodrai@linux.dev \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=kernel-team@meta.com \
--cc=mykolal@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox