From: Martin KaFai Lau <martin.lau@linux.dev>
To: tong@infragraf.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
Yonghong Song <yhs@fb.com>, KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Hou Tao <houtao1@huawei.com>,
bpf@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>
Subject: Re: [bpf-next v1] bpf: introduce stats update helper
Date: Fri, 3 Feb 2023 22:06:29 -0800 [thread overview]
Message-ID: <4da7e8dc-25cf-1c4a-bac0-1965df74b645@linux.dev> (raw)
In-Reply-To: <63ddd56327756_6bb1520881@john.notmuch>
On 2/3/23 7:47 PM, John Fastabend wrote:
> tong@ wrote:
>> From: Tonghao Zhang <tong@infragraf.org>
>>
>> This patch introduce a stats update helper to simplify codes.
>>
>> Signed-off-by: Tonghao Zhang <tong@infragraf.org>
>> Cc: Alexei Starovoitov <ast@kernel.org>
>> Cc: Daniel Borkmann <daniel@iogearbox.net>
>> Cc: Andrii Nakryiko <andrii@kernel.org>
>> Cc: Martin KaFai Lau <martin.lau@linux.dev>
>> Cc: Song Liu <song@kernel.org>
>> Cc: Yonghong Song <yhs@fb.com>
>> Cc: John Fastabend <john.fastabend@gmail.com>
>> Cc: KP Singh <kpsingh@kernel.org>
>> Cc: Stanislav Fomichev <sdf@google.com>
>> Cc: Hao Luo <haoluo@google.com>
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> Cc: Hou Tao <houtao1@huawei.com>
>> ---
>> include/linux/filter.h | 22 +++++++++++++++-------
>> kernel/bpf/trampoline.c | 10 +---------
>> 2 files changed, 16 insertions(+), 16 deletions(-)
>
> Seems fine but I'm not sure it makes much difference.
I also don't think it is needed. There are only two places. Also, it is not
encouraged to collect more stats. Refactoring it is not going to help in the future.
next prev parent reply other threads:[~2023-02-04 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:32 [bpf-next v1] bpf: introduce stats update helper tong
2023-02-04 3:47 ` John Fastabend
2023-02-04 6:06 ` Martin KaFai Lau [this message]
2023-02-06 1:05 ` Tonghao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4da7e8dc-25cf-1c4a-bac0-1965df74b645@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=houtao1@huawei.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=tong@infragraf.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox