From: Paolo Abeni <pabeni@redhat.com>
To: William Tu <witu@nvidia.com>, netdev@vger.kernel.org
Cc: u9012063@gmail.com, Martin Zaharinov <micron10@gmail.com>,
alexanderduyck@fb.com,
"<alexandr.lobakin@intel.com> <;hawk@kernel.org>"
<daniel@iogearbox.net>,
bpf@vger.kernel.org, john.fastabend@gmail.com,
pv-drivers@vmware.com, doshir@vmware.com
Subject: Re: [PATCH net] vmxnet3: Fix missing reserved tailroom
Date: Tue, 12 Mar 2024 11:56:39 +0100 [thread overview]
Message-ID: <5092d0d0c4b034e66645ffc974cf9d694f2bbb7f.camel@redhat.com> (raw)
In-Reply-To: <20240309183147.28222-1-witu@nvidia.com>
On Sat, 2024-03-09 at 20:31 +0200, William Tu wrote:
> Use rbi->len instead of rcd->len for non-dataring packet.
>
> Found issue:
> XDP_WARN: xdp_update_frame_from_buff(line:278): Driver BUG: missing reserved tailroom
> WARNING: CPU: 0 PID: 0 at net/core/xdp.c:586 xdp_warn+0xf/0x20
> CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W O 6.5.1 #1
> RIP: 0010:xdp_warn+0xf/0x20
> ...
> ? xdp_warn+0xf/0x20
> xdp_do_redirect+0x15f/0x1c0
> vmxnet3_run_xdp+0x17a/0x400 [vmxnet3]
> vmxnet3_process_xdp+0xe4/0x760 [vmxnet3]
> ? vmxnet3_tq_tx_complete.isra.0+0x21e/0x2c0 [vmxnet3]
> vmxnet3_rq_rx_complete+0x7ad/0x1120 [vmxnet3]
> vmxnet3_poll_rx_only+0x2d/0xa0 [vmxnet3]
> __napi_poll+0x20/0x180
> net_rx_action+0x177/0x390
>
> Reported-by: Martin Zaharinov <micron10@gmail.com>
> Tested-by: Martin Zaharinov <micron10@gmail.com>
> Link: https://lore.kernel.org/netdev/74BF3CC8-2A3A-44FF-98C2-1E20F110A92E@gmail.com/
> Fixes: 54f00cce1178 ("vmxnet3: Add XDP support.")
> Signed-off-by: William Tu <witu@nvidia.com>
> ---
> Note: this is a while ago in 2023, I forgot to send.
> https://lore.kernel.org/netdev/74BF3CC8-2A3A-44FF-98C2-1E20F110A92E@gmail.com/
The patch LGTM, but you omitted a quite long list of relevant
recipients, added now. Let's wait a bit more for some feedback.
Cheers,
Paolo
next parent reply other threads:[~2024-03-12 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240309183147.28222-1-witu@nvidia.com>
2024-03-12 10:56 ` Paolo Abeni [this message]
2024-03-12 11:39 ` [PATCH net] vmxnet3: Fix missing reserved tailroom Martin Zaharinov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5092d0d0c4b034e66645ffc974cf9d694f2bbb7f.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=alexanderduyck@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=doshir@vmware.com \
--cc=john.fastabend@gmail.com \
--cc=micron10@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=u9012063@gmail.com \
--cc=witu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox