From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B29AA440A32 for ; Sat, 17 Oct 2026 23:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792279966; cv=none; b=uYqEcD4K/at2GCiqYmLYBTOszJ6g9FuG60J6gQwnMPiYrfGdHFoHiJk2102NVUFdJLto48EYwlIBTh9zhd9shoFJZXOUC9m3USCoiNLuoAHShTIEferCqVmT/IuE/Z/1Jz7HDEhyUwHwhAKnZbX+BDkTIXEuBYtIvQaeJB9p2wo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792279966; c=relaxed/simple; bh=L50P2pMw33pTp3sRzxNv0eBE6m4qJyngdUpOBnnDTkc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WLieDprWINSNcSUC9gS+r1TXRIQpGO8hYUAIAxMdLIgrphB/9/tYy2j9ttcLpidCScMPwl9eva4lpfQes/Qdl/n+ku2nuX/Mu6gosqzAXkSC0rUjPMbGXxGFza6OJX1KiNQkxG9YDZPbvmzlHZ3mCcVwhgKyhjJ1Z6wKQ174eMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WwsGwIIy; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WwsGwIIy" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-35943f55c06so1416230eec.0 for ; Sat, 17 Oct 2026 16:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792279964; x=1792884764; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HZoGjmkdHdSYCxVMQUZJAUx+X9gAQBvlPFs22BIjZ94=; b=WwsGwIIyiGe0ic4SQYrsZmOcOynscObSSECpOZuTsj9F/YUw1eNns1JVizfk1aatrQ HjnVsaDumV4NSTAV96Z1mNdDXtLQ1WaD1T6VGn0DsvMW00N7KFC6uIeoAr1ElcZGsUH+ MUXpi6sX4tv1MffVTODhIu5+7yvBs8pX2s7vilicycjtIYue8Xg0v8piZfCmOdH0C0Qs 7+ad/wTjM0puAsN+xtuB5qnPLU0FoHcYJjwNJKEr6Wbmj2+/HNwejcJJB5GzA13N0wIL u6afkSRrhGWTMGFq8B386eg06Fdnkg/1QnuXpl29QDkXUiUdpnBedlhN1AQsT9GMkQLs ZPJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792279964; x=1792884764; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HZoGjmkdHdSYCxVMQUZJAUx+X9gAQBvlPFs22BIjZ94=; b=ScZPueUjT1z4m/s/pHIwEF3g1g05EgIkapo8E6011LKjhvt5ApXq1XaY/qcObxzz9J DTlG8cZtb5KCaQ/7/+VwVTS85WrveUCLK6joaab/NMvEM8VdNxw3azBReOgKXJtxkGIV VOFF6xHhW+x58cAW0Qv7GByx9ZKlyb4e/Qym6F+Tfhn7uK/DjuQ5vyc7Hr6WeSCvwxzj EwCxixqd6kHqeUZsB3jzON6KKZfB9cbvbOXMva0ZYv4vG3jzGuFNTxcYTqJpF2p0ZtWm /dQ4P8/cRgQTtxA5Yy4XgCSxBVk1g7NZZ7ZY0yNmEZ/ebJxlLuB59NR5Vl/HU/AqMVln SREw== X-Forwarded-Encrypted: i=1; AKwUvBzbGLsDvCm5vxrY4dGuDno4H3/tD+Lme30+ccBRiBfyRixxE4V1kAIT3GKhtd00NeXCBK0=@vger.kernel.org X-Gm-Message-State: AFq9FYLS4Ve9eGXx2g5EspXK08F+HZNBCPk0IDChwhDo7SZpXv2KumMe BlUIt4FmqC6s5Zhf1WWSnMGDJQuApFOkLtd8O6O28HnWMXIdME9/ucMO X-Gm-Gg: AYBFou1jyVC3chGXZeUAb+LWzaMW//GoU4P0KusAZ3PXkmdBBXOvBxSMZ2C9aBRuWwb JWi9rdZJAq4wBF5u/FUgiQ7zadent8q0BBw6hiuO0xjQKmZApR3Tamr4gAuqzi9G1HYYWuEaByx +2e1/7uvrupjoaxaxhW6If8aoM69qOfFMwzABgOO+k6pvpBwe5F8qsNeYGa6qW7YzRDeeCgc3To 4rHnhdCg1rSyxgpq+TLgoxY39BXtYZ5Kix4o2nZa7SPRj/rQniadVelmPgWW+FR/ZVXgPrBcyXc OFtSFgBzM7q1/9NOiQaif93yij+//Uz0d6MKNsL4tc/VUVrjyEaGf4PDrNiRurumX7vM6qVpcf9 3BzuBBKs8qbjgYv6vPpnhGQKK1KnCQDqQLB2FuxuK3ddps9JT1IDrfVCIr22Ltdm7Jzz4wSzvBW DEfHr80/2CqJXi2q1zawfJDbU69Qy7HOb3BcYLgwJsf2FsPX9tve06n8lLyHGNbZBw9OdSp4FMZ Ey13PzYvmV7evTe9OqQnRMyuWDhO4Ld8kCW X-Received: by 2002:a05:7301:5406:b0:355:29c0:9cac with SMTP id 5a478bee46e88-3602dcda842mr9448327eec.10.1792279963653; Sat, 17 Oct 2026 16:32:43 -0700 (PDT) Received: from ?IPV6:2620:10d:c085:21c8::1139? ([2620:10d:c090:400::5:8b32]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-360813b63e1sm20549691eec.8.2026.10.17.16.32.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Oct 2026 16:32:43 -0700 (PDT) Message-ID: <52539be1-2eeb-410a-83cf-0c79d1ca40ef@gmail.com> Date: Sat, 17 Oct 2026 16:32:41 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 1/2] veth: schedule the peer's NAPI after XDP_TX when only GRO is enabled To: Tianyi Gao , netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, toke@redhat.com, horms@kernel.org, bpf@vger.kernel.org, shuah@kernel.org, hawk@kernel.org, kernel-team@cloudflare.com, ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, sdf@fomichev.me, linux-kselftest@vger.kernel.org, bochaolucky@gmail.com, toshiaki.makita1@gmail.com, lorenzo@kernel.org References: <20261016214217.16942-1-tianyi@cloudflare.com> <20261016214217.16942-2-tianyi@cloudflare.com> Content-Language: en-US From: Mohsin Bashir In-Reply-To: <20261016214217.16942-2-tianyi@cloudflare.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/16/26 2:42 PM, Tianyi Gao wrote: > veth_xdp_xmit() queues XDP_TX frames on the peer's ring if the peer has > NAPI. A peer with GRO enabled and no XDP program also has NAPI. > > veth_xdp_flush() then schedules the peer's NAPI, but only if the peer's > xdp_prog is set, so for such a peer the frames are never processed. > Nothing else schedules that NAPI by default. > > Once the ring is full, every XDP_TX frame is dropped, and so are the > skbs that veth_xmit() queues on the same ring. > > Commit 0e672f306a28 ("veth: check for NAPI instead of xdp_prog before > xmit of XDP frame") changed the check in veth_xdp_xmit() but not the one > in veth_xdp_flush(). Make veth_xdp_flush() check the napi pointer > instead of xdp_prog, as veth_xdp_xmit() does. > > Fixes: 0e672f306a28 ("veth: check for NAPI instead of xdp_prog before xmit of XDP frame") > Signed-off-by: Tianyi Gao > --- > drivers/net/veth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > index 643b97dc5245..9405ffac598a 100644 > --- a/drivers/net/veth.c > +++ b/drivers/net/veth.c > @@ -612,7 +612,7 @@ static void veth_xdp_flush(struct veth_rq *rq, struct veth_xdp_tx_bq *bq) > rcv_priv = netdev_priv(rcv); > rcv_rq = &rcv_priv->rq[veth_select_rxq(rcv)]; > /* xdp_ring is initialized on receive side? */ > - if (unlikely(!rcu_access_pointer(rcv_rq->xdp_prog))) > + if (unlikely(!rcu_access_pointer(rcv_rq->napi))) > goto out; > > __veth_xdp_flush(rcv_rq); Reviewed-by: Mohsin Bashir