From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B54021422C6 for ; Mon, 8 Apr 2024 15:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712591750; cv=none; b=pX/sJ019Ktwu5rd9DHgLiRe+VwwsE1vuM6VBeExm7RzxEfF+BMJubjnvZs/xFZrQtYIt140AUvT+UawdWUbG0cEIxGbNSRfsDpadRcD3OigO1X0fQNpfkCJJz0pSlm2CcpCExfTxTdHHLSRKeWcBsbSspEAsFLbWnhHa3EwADLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712591750; c=relaxed/simple; bh=zqADHLr4EY/EAx3DE/mqSZnQVLiRxCcE2lbCRkeKNvs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vF9MMHgezYBG7/VZHcZfZjKL70Fn1drZmmkFPfJpTYSf5S3V2TNMdb7G7Vx3ox9eFZh/1aKxHwrj4FC24vsyuHF2q+5qPbM46JSjBkF58GB410kYYFjXjuSm6TCwZkCOYH/OMYVtJ4VdSFcI1fqXhh2ZhPXAIiEInKOBPEMZ9TY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lt0cw3ly; arc=none smtp.client-ip=95.215.58.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lt0cw3ly" Message-ID: <53d74f8b-6c3b-4486-9ebd-8d934d05def1@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712591746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1frtsh0j0ZkvlwOfgeUPcyDzLBEBc8llklyMJfKmSCw=; b=lt0cw3lyx0R1w74upPNzJTGGLysim/E5zVACi2m+sam8kofOHtdrPQ7iN+iQ/uMszKV6M1 1fH/qWEEoPXvEuns7th/OMGsNdqcPoNmcCFGsv3xGsE0z+kP1/zeM5MGwaJiMbOUM7TKB6 Di8LGCFcZvvP2fTXyllPXqelL7y34oE= Date: Mon, 8 Apr 2024 08:55:38 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v3 2/2] selftests/bpf: Fix umount cgroup2 error in test_sockmap Content-Language: en-GB To: Geliang Tang , Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Jakub Sitnicki Cc: Geliang Tang , bpf@vger.kernel.org, mptcp@lists.linux.dev References: <5dcde0bcff8d37a5ffe61dbd51848385ddaf2951.1712539403.git.tanggeliang@kylinos.cn> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <5dcde0bcff8d37a5ffe61dbd51848385ddaf2951.1712539403.git.tanggeliang@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 4/7/24 6:36 PM, Geliang Tang wrote: > From: Geliang Tang > > This patch fixes the following "umount cgroup2" error in test_sockmap.c: > > (cgroup_helpers.c:353: errno: Device or resource busy) umount cgroup2 > > Cgroup fd cg_fd should be closed before cleanup_cgroup_environment(). > > Fixes: 13a5f3ffd202 ("bpf: Selftests, sockmap test prog run without setting cgroup") > Signed-off-by: Geliang Tang Acked-by: Yonghong Song