From: Paolo Abeni <pabeni@redhat.com>
To: Jason Xing <kerneljasonxing@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
bjorn@kernel.org, magnus.karlsson@intel.com,
maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com,
sdf@fomichev.me, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, joe@dama.to,
willemdebruijn.kernel@gmail.com
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [PATCH net-next v2] xsk: add indirect call for xsk_destruct_skb
Date: Thu, 30 Oct 2025 11:15:18 +0100 [thread overview]
Message-ID: <54d1ac44-8e53-4056-8061-0c620d9ec4bf@redhat.com> (raw)
In-Reply-To: <20251026145824.81675-1-kerneljasonxing@gmail.com>
On 10/26/25 3:58 PM, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
>
> Since Eric proposed an idea about adding indirect call for UDP and
Minor nit: ^^^^^^
either 'remove an indirect call' or 'adding indirect call wrappers'
> managed to see a huge improvement[1], the same situation can also be
> applied in xsk scenario.
>
> This patch adds an indirect call for xsk and helps current copy mode
> improve the performance by around 1% stably which was observed with
> IXGBE at 10Gb/sec loaded.
If I follow the conversation correctly, Jakub's concern is mostly about
this change affecting only the copy mode.
Out of sheer ignorance on my side is not clear how frequent that
scenario is. AFAICS, applications could always do zero-copy with proper
setup, am I correct?!?
In such case I think this patch is not worth.
Otherwise, please describe/explain the real-use case needing the copy mode.
Thanks,
Paolo
next prev parent reply other threads:[~2025-10-30 10:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 14:58 [PATCH net-next v2] xsk: add indirect call for xsk_destruct_skb Jason Xing
2025-10-27 15:21 ` Alexander Lobakin
2025-10-29 0:30 ` Jakub Kicinski
2025-10-29 1:15 ` Jason Xing
2025-10-30 10:15 ` Paolo Abeni [this message]
2025-10-30 10:28 ` Jason Xing
2025-10-30 10:59 ` Alexander Lobakin
2025-10-30 11:17 ` Jason Xing
2025-10-30 15:55 ` Jakub Kicinski
2025-10-30 16:43 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54d1ac44-8e53-4056-8061-0c620d9ec4bf@redhat.com \
--to=pabeni@redhat.com \
--cc=aleksander.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=joe@dama.to \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).