From: Eduard Zingerman <eddyz87@gmail.com>
To: Leon Hwang <hffilwlqm@gmail.com>, bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
maciej.fijalkowski@intel.com, puranjay@kernel.org,
jakub@cloudflare.com, pulehui@huawei.com,
kernel-patches-bot@fb.com
Subject: Re: [PATCH v5 bpf-next 3/3] selftests/bpf: Add testcases for tailcall hierarchy fixing
Date: Wed, 10 Jul 2024 19:01:48 -0700 [thread overview]
Message-ID: <5665eb1f4217948a3a06b6898762abf719f141cd.camel@gmail.com> (raw)
In-Reply-To: <20240623161528.68946-4-hffilwlqm@gmail.com>
On Mon, 2024-06-24 at 00:15 +0800, Leon Hwang wrote:
> Add some test cases to confirm the tailcall hierarchy issue has been fixed.
>
> On x64, the selftests result is:
>
> cd tools/testing/selftests/bpf && ./test_progs -t tailcalls
> 327/18 tailcalls/tailcall_bpf2bpf_hierarchy_1:OK
> 327/19 tailcalls/tailcall_bpf2bpf_hierarchy_fentry:OK
> 327/20 tailcalls/tailcall_bpf2bpf_hierarchy_fexit:OK
> 327/21 tailcalls/tailcall_bpf2bpf_hierarchy_fentry_fexit:OK
> 327/22 tailcalls/tailcall_bpf2bpf_hierarchy_fentry_entry:OK
> 327/23 tailcalls/tailcall_bpf2bpf_hierarchy_2:OK
> 327/24 tailcalls/tailcall_bpf2bpf_hierarchy_3:OK
> 327 tailcalls:OK
> Summary: 1/24 PASSED, 0 SKIPPED, 0 FAILED
>
> On arm64, the selftests result is:
>
> cd tools/testing/selftests/bpf && ./test_progs -t tailcalls
> 327/18 tailcalls/tailcall_bpf2bpf_hierarchy_1:OK
> 327/19 tailcalls/tailcall_bpf2bpf_hierarchy_fentry:OK
> 327/20 tailcalls/tailcall_bpf2bpf_hierarchy_fexit:OK
> 327/21 tailcalls/tailcall_bpf2bpf_hierarchy_fentry_fexit:OK
> 327/22 tailcalls/tailcall_bpf2bpf_hierarchy_fentry_entry:OK
> 327/23 tailcalls/tailcall_bpf2bpf_hierarchy_2:OK
> 327/24 tailcalls/tailcall_bpf2bpf_hierarchy_3:OK
> 327 tailcalls:OK
> Summary: 1/24 PASSED, 0 SKIPPED, 0 FAILED
>
> Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
> ---
Nitpick:
I think that test cases *_hierarchy_{2,3} could be rewritten as
example by this link:
https://gist.github.com/eddyz87/af9b50d0ff3802b43f0e148591790017
It uses test_loader.c machinery, you can use RUN_TESTS macro from any
prog_tests/*.c file to run test cases from a specific binary file.
Otherwise these test cases look good to me.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...]
next prev parent reply other threads:[~2024-07-11 2:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 16:15 [PATCH v5 bpf-next 0/3] bpf: Fix tailcall hierarchy Leon Hwang
2024-06-23 16:15 ` [PATCH v5 bpf-next 1/3] bpf, x64: " Leon Hwang
2024-07-11 0:15 ` Eduard Zingerman
2024-07-11 2:02 ` Leon Hwang
2024-06-23 16:15 ` [PATCH v5 bpf-next 2/3] bpf, arm64: " Leon Hwang
2024-06-26 12:05 ` Puranjay Mohan
2024-06-23 16:15 ` [PATCH v5 bpf-next 3/3] selftests/bpf: Add testcases for tailcall hierarchy fixing Leon Hwang
2024-07-11 2:01 ` Eduard Zingerman [this message]
2024-07-11 14:36 ` Leon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5665eb1f4217948a3a06b6898762abf719f141cd.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hffilwlqm@gmail.com \
--cc=jakub@cloudflare.com \
--cc=kernel-patches-bot@fb.com \
--cc=maciej.fijalkowski@intel.com \
--cc=pulehui@huawei.com \
--cc=puranjay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox