From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E6C18529E for ; Fri, 12 Apr 2024 14:01:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712930501; cv=none; b=IgcSMrB2qrAdnzyNuj9ldqC3XdmUgvD+1bQjWTOGa4a5WLGHOG8kPCXBf2sKGZPhgvFLgt3hX+3+4K30eDDLkcrwH4XANrZhm27R2vvalk146h8mnJZLA5PO3aYkWFgCoIv5QR8LkMZKGAjBRRkqrYMhmRKHJo+C741A6pBEP1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712930501; c=relaxed/simple; bh=wM/qLHmObCPp0A36qPqz30NvxHM7nS4FGirrfQUSiU8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HwEg+anKzbynFE596OT3szyW/Pq/i/oSbG6ZjCeGTc7hge/1KdNQL0tjLcEh0ys7yktfqydP8DHof/+aCO7m0Ei6095Y+r58C0fJA12wj/I5LikvZuzyWHg13/iOD/MRU1xc4vRePNR95K5M8huqfHkPKpUCqTFrHQO76EiF0U8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=KjvAgDC/; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="KjvAgDC/" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-518931f8d23so376097e87.3 for ; Fri, 12 Apr 2024 07:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1712930494; x=1713535294; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wM/qLHmObCPp0A36qPqz30NvxHM7nS4FGirrfQUSiU8=; b=KjvAgDC/Vs14VfzWr/+5EXa+gZ1XehbDgAxVoHuDimFLCGf3QYzdDUx1GutjUqfN02 nIGw6IibMrqmFZ3Jl8k1hal0h+b/Pykeo0ZEGzGXsj9HLdPX2jHUqa/QaNUUwyhTQ87k AgdY4AgA/oy1gLok9pK20N5abY4hjTsPd00BsaVFWemu3PuEzduqXOqbe/jZ5roIct0i IxzUh+inxq+M/hO8USWwafe0jS9/VBNXyn/bH9Dvqfxtynbx9U/KI2stXjBVwUUKkBTs xJH5mzL3nIHW6qL+fJ+cPldFlovgOmDX6PoBzjUDn+dAlwA9XBMhG03wZLdpXfKgXTyM MDFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712930494; x=1713535294; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wM/qLHmObCPp0A36qPqz30NvxHM7nS4FGirrfQUSiU8=; b=IxOUWgNmRENRZx3lTlfvsMF9/td0sPNXscmaL88qggvETt9wxm7N1F/o/jeNHVeJLg mIEgHqbO3mLfXThdS7G1kC0fwXdzwAtu1ZLUQx1kv5W3WUYAfG+67AjvujChSEpE/0cQ pnEGj2/8sl9iIbHv6V/rAZE9B5eRvtR4/Vqa5eevcHaZlVgiI7b5+nvcbjW5PMgMDGSe sQRhi/k837Ki+brTJVyT6WB1FuY2SAHaotWhk+TaT9SblAzUBZzg3tTs31k9wR27Y+GR yAWeu+Qc9gGqgZAer95JU2VNvFABQdCp31dOx13dxnM1DcUHolqP0xdKBewzmM5J2hjI ebSg== X-Forwarded-Encrypted: i=1; AJvYcCW1yG1uLuphADVAOn4iaSKXgOZxoq9mRjSBXDYBUz6qFhDn87VDX7Ir99+g7J3rjJkI8UDuzR9kMQh1g9qkAvSdpLnc X-Gm-Message-State: AOJu0Yw1TMFuF/nbwG3P0WOChuDxRSTMMluMyPAs/xZCDR8hbcvUdtJc kT5mX/hChu9iiBkI76xcNxwnUhFC0k/wGsi0yDiFzD14wMycIjNuVG1mQlIGN+I= X-Google-Smtp-Source: AGHT+IEYkdfZvzjzQTuqNwyv3/1I2wTibAdy/3l+Tqdqfg9DbDMvxlxElX4Ty3O747WwsNgGkO2d6A== X-Received: by 2002:ac2:44c7:0:b0:516:cc9f:f8a with SMTP id d7-20020ac244c7000000b00516cc9f0f8amr1646189lfm.66.1712930494023; Fri, 12 Apr 2024 07:01:34 -0700 (PDT) Received: from [192.168.1.70] ([84.102.31.74]) by smtp.gmail.com with ESMTPSA id u7-20020adfeb47000000b0033ec9ddc638sm4339471wrn.31.2024.04.12.07.01.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Apr 2024 07:01:33 -0700 (PDT) Message-ID: <568a7740-ff47-49f0-978d-14cfe14f2b80@baylibre.com> Date: Fri, 12 Apr 2024 16:01:30 +0200 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v8 0/3] Add minimal XDP support to TI AM65 CPSW Ethernet driver To: Jacob Keller , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Simon Horman , Andrew Lunn , Ratheesh Kannoth , Naveen Mamindlapalli Cc: danishanwar@ti.com, yuehaibing@huawei.com, rogerq@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org References: <20240223-am65-cpsw-xdp-basic-v8-0-f3421b58da09@baylibre.com> Content-Language: en-US From: Julien Panis In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/10/24 01:51, Jacob Keller wrote: > > On 4/8/2024 2:38 AM, Julien Panis wrote: >> This patch adds XDP support to TI AM65 CPSW Ethernet driver. >> >> The following features are implemented: NETDEV_XDP_ACT_BASIC, >> NETDEV_XDP_ACT_REDIRECT, and NETDEV_XDP_ACT_NDO_XMIT. >> >> Zero-copy and non-linear XDP buffer supports are NOT implemented. >> >> Besides, the page pool memory model is used to get better performance. >> >> Signed-off-by: Julien Panis >> --- > Reviewed-by: Jacob Keller Thank you for your review Jacob. I'll add your 'Reviewed-by' tag for PATCH 1/3 in next version. Unfortunately, I will not for PATCH 2/3 and 3/3 because there will be too many changes, following Jakub's comments.