From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bpf-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 85930C433EF
	for <bpf@archiver.kernel.org>; Wed, 13 Jul 2022 14:44:24 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231703AbiGMOoX (ORCPT <rfc822;bpf@archiver.kernel.org>);
        Wed, 13 Jul 2022 10:44:23 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48886 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S236093AbiGMOoQ (ORCPT <rfc822;bpf@vger.kernel.org>);
        Wed, 13 Jul 2022 10:44:16 -0400
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id E40EF1FCEC;
        Wed, 13 Jul 2022 07:44:15 -0700 (PDT)
Received: from pwmachine.localnet (240.119.92.79.rev.sfr.net [79.92.119.240])
        by linux.microsoft.com (Postfix) with ESMTPSA id 2EBE6204DE98;
        Wed, 13 Jul 2022 07:44:13 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2EBE6204DE98
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
        s=default; t=1657723455;
        bh=nVPYGVEqgFvdgKTCaucYk9KATG8V1rjN5GDIXGgYphk=;
        h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
        b=cihL9RYMaV7+hjbuk+5xX8Cz/Htlqhku1rxIZ1aPvwJ9BJZJUmTmcybPWc6ftU6aK
         dUyGkSh3cTi3+GKXNR6JtJjfeygBxqnUpE9xx5+7pvso4aZQqGaGql4+GgUcTR3g8u
         0/w0KyRWUbgYqvD6Kd7DH2HPzbDjhYvYpHStPTDQ=
From:   Francis Laniel <flaniel@linux.microsoft.com>
To:     bpf@vger.kernel.org, Quentin Monnet <quentin@isovalent.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2 1/1] bpftool: Align dumped file headers with skeletons.
Date:   Wed, 13 Jul 2022 16:44:10 +0200
Message-ID: <5839621.lOV4Wx5bFT@pwmachine>
Organization: Microsoft
In-Reply-To: <e1b00ebf-fb06-6eb3-2fa2-7e7155594626@isovalent.com>
References: <20220713134046.15020-1-flaniel@linux.microsoft.com> <20220713134046.15020-2-flaniel@linux.microsoft.com> <e1b00ebf-fb06-6eb3-2fa2-7e7155594626@isovalent.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk
List-ID: <bpf.vger.kernel.org>
X-Mailing-List: bpf@vger.kernel.org

Le mercredi 13 juillet 2022, 15:57:13 CEST Quentin Monnet a =E9crit :
> On 13/07/2022 14:40, Francis Laniel wrote:
> > This commit adds the following lines to file generated by dump:
> > /* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
> > /* THIS FILE IS AUTOGENERATED BY BPFTOOL! */
> > Hence, the dumped file headers follows that of skeletons.
> >=20
> > Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
> > ---
> >=20
> >  tools/bpf/bpftool/btf.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >=20
> > diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c
> > index 7e6accb9d9f7..066a0acd0ecd 100644
> > --- a/tools/bpf/bpftool/btf.c
> > +++ b/tools/bpf/bpftool/btf.c
> > @@ -425,6 +425,8 @@ static int dump_btf_c(const struct btf *btf,
> >=20
> >  	if (err)
> >  =09
> >  		return err;
> >=20
> > +	printf("/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */\n");
> > +	printf("/* THIS FILE IS AUTOGENERATED BY BPFTOOL! */\n");
> >=20
> >  	printf("#ifndef __VMLINUX_H__\n");
> >  	printf("#define __VMLINUX_H__\n");
> >  	printf("\n");
>=20
> Looks good, simpler than v1, thank you!
>=20
> Reviewed-by: Quentin Monnet <quentin@isovalent.com>

Thank you for the review!