From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org, kernel-team@meta.com
Subject: Re: [PATCH bpf-next] selftests/bpf: validate eliminated global subprog is not freplaceable
Date: Fri, 01 Dec 2023 21:20:31 +0200 [thread overview]
Message-ID: <583eb34882904c94f74a737650c20ac2d2fe18fa.camel@gmail.com> (raw)
In-Reply-To: <CAEf4BzYgdX4m15fV9Xujk8RRDbwNH5zWuV6Wb+k2+NXigJ5nNA@mail.gmail.com>
On Fri, 2023-12-01 at 11:17 -0800, Andrii Nakryiko wrote:
[...]
> > Acked-by: Eduard Zingerman <eddyz87@gmail.com>
>
> Oops, didn't see your reply before sending v2. But there will be v3 anyway :)
np
[...]
> > Nit: the log is not printed if verbose tests execution is requested.
>
> I'm not sure I understand. What do you expect to happen that's not
> happening in verbose mode?
I tried running this test -vvv and it did not print verification log
(admittedly this is the case with many tests in prog_tests/*.c).
[...]
> > Nit/question:
> > Why change prototype from (void) to (int) here and elsewhere?
> > Does not seem necessary for test logic.
>
> I had some troubles attaching freplace initially, but my freplace
> skills were rusty :) I can try undoing this and leaving it as is.
No strong opinion, just curious.
next prev parent reply other threads:[~2023-12-01 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 1:30 [PATCH bpf-next] selftests/bpf: validate eliminated global subprog is not freplaceable Andrii Nakryiko
2023-12-01 15:16 ` Eduard Zingerman
2023-12-01 19:17 ` Andrii Nakryiko
2023-12-01 19:20 ` Eduard Zingerman [this message]
2023-12-01 19:26 ` Andrii Nakryiko
2023-12-01 20:02 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583eb34882904c94f74a737650c20ac2d2fe18fa.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox