From: Mukesh Ojha <mojha@codeaurora.org>
To: jagdsh.linux@gmail.com, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org, ast@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
yao.jin@linux.intel.com, eranian@google.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH] tools/perf/util: Remove duplicate headers
Date: Thu, 28 Mar 2019 11:57:13 +0530 [thread overview]
Message-ID: <599c35c3-88b8-f007-9eee-d7fddb1cb31b@codeaurora.org> (raw)
In-Reply-To: <1553724446-40957-1-git-send-email-jagdsh.linux@gmail.com>
On 3/28/2019 3:37 AM, jagdsh.linux@gmail.com wrote:
> From: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
>
> Remove duplicate headers which are included twice.
> Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
-Mukesh
> ---
> tools/perf/util/annotate.c | 1 -
> tools/perf/util/data.c | 1 -
> tools/perf/util/get_current_dir_name.c | 1 -
> tools/perf/util/stat-display.c | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index c8b0117..b1dd021 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -36,7 +36,6 @@
> #include <pthread.h>
> #include <linux/bitops.h>
> #include <linux/kernel.h>
> -#include <bpf/libbpf.h>
>
> /* FIXME: For the HE_COLORSET */
> #include "ui/browser.h"
> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> index 6a64f71..509a41e 100644
> --- a/tools/perf/util/data.c
> +++ b/tools/perf/util/data.c
> @@ -8,7 +8,6 @@
> #include <unistd.h>
> #include <string.h>
> #include <asm/bug.h>
> -#include <sys/types.h>
> #include <dirent.h>
>
> #include "data.h"
> diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> index 267aa60..ebb80cd 100644
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -5,7 +5,6 @@
> #include "util.h"
> #include <unistd.h>
> #include <stdlib.h>
> -#include <stdlib.h>
>
> /* Android's 'bionic' library, for one, doesn't have this */
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 6d043c7..7b3a16c 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -12,7 +12,6 @@
> #include "string2.h"
> #include "sane_ctype.h"
> #include "cgroup.h"
> -#include <math.h>
> #include <api/fs/fs.h>
>
> #define CNTR_NOT_SUPPORTED "<not supported>"
next prev parent reply other threads:[~2019-03-28 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 22:07 [PATCH] tools/perf/util: Remove duplicate headers jagdsh.linux
2019-03-28 6:27 ` Mukesh Ojha [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-19 6:36 jagdsh.linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599c35c3-88b8-f007-9eee-d7fddb1cb31b@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=eranian@google.com \
--cc=jagdsh.linux@gmail.com \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=yao.jin@linux.intel.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).