From: Eduard Zingerman <eddyz87@gmail.com>
To: Ihor Solodrai <ihor.solodrai@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: Alan Maguire <alan.maguire@oracle.com>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
bpf@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH bpf-next v1 4/4] selftests/bpf: Add kfunc set test to resolve_btfids
Date: Thu, 18 Jun 2026 18:01:28 -0700 [thread overview]
Message-ID: <5c88bd7f01c7c156bb112f0f720dc9faffc7363b.camel@gmail.com> (raw)
In-Reply-To: <20260617210619.1562858-5-ihor.solodrai@linux.dev>
On Wed, 2026-06-17 at 14:06 -0700, Ihor Solodrai wrote:
[...]
> @@ -161,6 +189,27 @@ void test_resolve_btfids(void)
> ASSERT_LE(test_set.ids[i - 1], test_set.ids[i], "sort_check");
> }
>
> + /* Check BTF_KFUNCS_START(test_kfunc_set) */
> + ASSERT_EQ(test_kfunc_set.flags, BTF_SET8_KFUNCS, "kfunc_set_flags");
> + ASSERT_EQ(test_kfunc_set.cnt, ARRAY_SIZE(kfunc_symbols), "kfunc_set_cnt");
> +
> + for (i = 0; i < test_kfunc_set.cnt; i++) {
> + for (j = 0; j < ARRAY_SIZE(kfunc_symbols); j++) {
> + if (kfunc_symbols[j].id == (s32)test_kfunc_set.pairs[i].id) {
> + ASSERT_EQ(test_kfunc_set.pairs[i].flags,
> + kfunc_symbols[j].flags, "kfunc_flags_check");
> + break;
> + }
> + }
> +
> + ASSERT_TRUE(j < ARRAY_SIZE(kfunc_symbols), "kfunc_id_found");
> +
> + if (i > 0) {
> + ASSERT_LE(test_kfunc_set.pairs[i - 1].id,
> + test_kfunc_set.pairs[i].id, "kfunc_sort_check");
> + }
To assert the sorted property, should one define two sets?
{ a, b } and { b, a }? And check both.
Otherwise the id assignments might be an artifact of compiler BTF
generation logic.
> + }
> +
> out:
> btf__free(btf);
> }
[...]
next prev parent reply other threads:[~2026-06-19 1:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 21:06 [PATCH bpf-next v1 0/4] Modernize resolve_btfids selftest Ihor Solodrai
2026-06-17 21:06 ` [PATCH bpf-next v1 1/4] tools/bpf: Sync btf_ids.h to tools Ihor Solodrai
2026-06-19 0:30 ` Eduard Zingerman
2026-06-17 21:06 ` [PATCH bpf-next v1 2/4] selftests/bpf: Modernize resolve_btfids test scaffolding Ihor Solodrai
2026-06-19 0:30 ` Eduard Zingerman
2026-06-17 21:06 ` [PATCH bpf-next v1 3/4] selftests/bpf: Fix resolve_btfids test reads of BTF ID sets in PIE builds Ihor Solodrai
2026-06-17 21:06 ` [PATCH bpf-next v1 4/4] selftests/bpf: Add kfunc set test to resolve_btfids Ihor Solodrai
2026-06-18 12:31 ` Jiri Olsa
2026-06-24 0:59 ` Ihor Solodrai
2026-06-19 1:01 ` Eduard Zingerman [this message]
2026-06-18 12:32 ` [PATCH bpf-next v1 0/4] Modernize resolve_btfids selftest Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c88bd7f01c7c156bb112f0f720dc9faffc7363b.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox