From: Martin KaFai Lau <martin.lau@linux.dev>
To: Stanislav Fomichev <sdf@google.com>, bpf <bpf@vger.kernel.org>
Subject: [Question]: BPF_CGROUP_{GET,SET}SOCKOPT handling when optlen > PAGE_SIZE
Date: Wed, 26 Oct 2022 18:14:08 -0700 [thread overview]
Message-ID: <5c8b7d59-1f28-2284-f7b9-49d946f2e982@linux.dev> (raw)
The cgroup-bpf {get,set}sockopt prog is useful to change the optname behavior.
The bpf prog usually just handles a few specific optnames and ignores most
others. For the optnames that it ignores, it usually does not need to change
the optlen. The exception is when optlen > PAGE_SIZE (or optval_end - optval).
The bpf prog needs to set the optlen to 0 for this case or else the kernel will
return -EFAULT to the userspace. It is usually not what the bpf prog wants
because the bpf prog only expects error returning to userspace when it has
explicitly 'return 0;' or used bpf_set_retval(). If a bpf prog always changes
optlen for optnames that it does not care to 0, it may risk if the latter bpf
prog in the same cgroup may want to change/look-at it.
Would like to explore if there is an easier way for the bpf prog to handle it.
eg. does it make sense to track if the bpf prog has changed the ctx->optlen
before returning -EFAULT to the user space when ctx.optlen > max_optlen?
next reply other threads:[~2022-10-27 1:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 1:14 Martin KaFai Lau [this message]
2022-10-27 2:03 ` [Question]: BPF_CGROUP_{GET,SET}SOCKOPT handling when optlen > PAGE_SIZE Stanislav Fomichev
2022-10-27 6:15 ` Martin KaFai Lau
2022-10-27 16:23 ` Stanislav Fomichev
2022-10-27 17:28 ` Martin KaFai Lau
2022-10-27 17:40 ` Stanislav Fomichev
2022-10-27 18:48 ` Martin KaFai Lau
2022-10-27 19:11 ` Stanislav Fomichev
2022-10-27 20:04 ` Martin KaFai Lau
2022-10-27 20:14 ` Stanislav Fomichev
2022-10-27 20:46 ` Andrii Nakryiko
2022-10-27 23:46 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c8b7d59-1f28-2284-f7b9-49d946f2e982@linux.dev \
--to=martin.lau@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox