BPF List
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
	daniel@iogearbox.net,  martin.lau@linux.dev, kernel-team@fb.com,
	yonghong.song@linux.dev,  hffilwlqm@gmail.com
Subject: Re: [PATCH bpf-next v2 2/4] selftests/bpf: utility function to get program disassembly after jit
Date: Thu, 15 Aug 2024 15:13:28 -0700	[thread overview]
Message-ID: <5d726519a30c9e1c8e5e3250ec8d51af988bedea.camel@gmail.com> (raw)
In-Reply-To: <CAEf4BzZdf4JRrvm71hTKUii4REpBQRHb=KWsm8ku+8gLdxjbjg@mail.gmail.com>

On Thu, 2024-08-15 at 15:10 -0700, Andrii Nakryiko wrote:

[...]

> > For the block above the lines are indented using two spaces and four spaces.
> > This is not a rule body, so should not be a problem afaik.
> > What's not working on your side?
> > 
> 
> oh, it's just for consistency with the rest of Makefile. We use tabs
> for indentation, so let's stay consistent.

Ok, will change

[...]


  reply	other threads:[~2024-08-15 22:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 20:54 [PATCH bpf-next v2 0/4] __jited_x86 test tag to check x86 assembly after jit Eduard Zingerman
2024-08-15 20:54 ` [PATCH bpf-next v2 1/4] selftests/bpf: less spam in the log for message matching Eduard Zingerman
2024-08-15 20:54 ` [PATCH bpf-next v2 2/4] selftests/bpf: utility function to get program disassembly after jit Eduard Zingerman
2024-08-15 21:17   ` Andrii Nakryiko
2024-08-15 21:54     ` Eduard Zingerman
2024-08-15 22:10       ` Andrii Nakryiko
2024-08-15 22:13         ` Eduard Zingerman [this message]
2024-08-15 20:54 ` [PATCH bpf-next v2 3/4] selftests/bpf: __jited_x86 test tag to check x86 assembly " Eduard Zingerman
2024-08-15 20:54 ` [PATCH bpf-next v2 4/4] selftests/bpf: validate jit behaviour for tail calls Eduard Zingerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d726519a30c9e1c8e5e3250ec8d51af988bedea.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=hffilwlqm@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=martin.lau@linux.dev \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox