From: John Fastabend <john.fastabend@gmail.com>
To: Xin Hao <xhao@linux.alibaba.com>, ast@kernel.org
Cc: daniel@iogearbox.net, kafai@fb.com, andriin@fb.com,
xhao@linux.alibaba.com, bpf@vger.kernel.org
Subject: RE: [bpf-next 1/3] sample/bpf: Avoid repetitive definition of log2 func
Date: Mon, 21 Sep 2020 09:56:43 -0700 [thread overview]
Message-ID: <5f68db4bfe4a_17370208fc@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20200920144547.56771-2-xhao@linux.alibaba.com>
Xin Hao wrote:
> log2 func is defined and used in following three files:
> samples/bpf/lathist_kern.c
> samples/bpf/lwt_len_hist_kern.c
> samples/bpf/tracex2_kern.c
>
> There's no need to repeat define them many times, so i added
> a "common.h" file which maintains common codes, you just need
> to include it in your file and future we can put more common codes
> into this file.
>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
> ---
LGTM
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2020-09-21 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 14:45 [bpf-next 0/3] Using log2 histogram to display the statistics of every softirq execution Xin Hao
2020-09-20 14:45 ` [bpf-next 1/3] sample/bpf: Avoid repetitive definition of log2 func Xin Hao
2020-09-21 16:56 ` John Fastabend [this message]
2020-09-20 14:45 ` [bpf-next 2/3] sample/bpf: Add log2 histogram function support Xin Hao
2020-09-21 17:16 ` John Fastabend
2020-09-21 21:40 ` Andrii Nakryiko
2020-09-22 2:06 ` Xin Hao
2020-09-23 5:32 ` Wenbo Zhang
2020-09-20 14:45 ` [bpf-next 3/3] samples/bpf: Add soft irq execution time statistics Xin Hao
2020-09-21 17:33 ` John Fastabend
2020-09-21 21:33 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f68db4bfe4a_17370208fc@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=xhao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox