From: Matthieu Baerts <matttbe@kernel.org>
To: Martin KaFai Lau <martin.lau@linux.dev>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, MPTCP Upstream <mptcp@lists.linux.dev>,
Mat Martineau <martineau@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>,
Geliang Tang <geliang@kernel.org>
Subject: Re: mptcp splat
Date: Thu, 28 Mar 2024 18:35:00 +0100 [thread overview]
Message-ID: <5fe3398c-0ed6-48b8-a5b4-2cc7329b554a@kernel.org> (raw)
In-Reply-To: <649dc1dc-ca80-4686-ae37-62d7c81dde8b@linux.dev>
Hi Martin,
On 27/03/2024 23:16, Martin KaFai Lau wrote:
(...)
> Unrelated, is there a way to tell if a tcp_sock is a subflow?
Yes, you can use "sk_is_mptcp(sk)". Please note that this 'sk' *has* to
be a tcp_sock, this is not checked by the helper.
That's what is used with bpf_mptcp_sock_from_subflow()
https://elixir.bootlin.com/linux/latest/source/net/mptcp/bpf.c#L15
> bpf prog
> can use it to decide if it wants to setsockopt on a subflow or not.
I think it is important to keep the possibility to set socket options
per subflow. If the original issue discussed here is limited to
set_rcvlowat(), best to address it there.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-03-28 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 16:43 mptcp splat Alexei Starovoitov
2024-03-27 16:56 ` Paolo Abeni
2024-03-27 17:00 ` Alexei Starovoitov
2024-03-27 18:32 ` Paolo Abeni
2024-03-27 18:45 ` Mat Martineau
2024-03-27 18:50 ` Alexei Starovoitov
2024-03-27 22:16 ` Martin KaFai Lau
2024-03-28 17:35 ` Matthieu Baerts [this message]
2024-03-29 16:26 ` Alexei Starovoitov
2024-03-29 16:34 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fe3398c-0ed6-48b8-a5b4-2cc7329b554a@kernel.org \
--to=matttbe@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=geliang@kernel.org \
--cc=kuba@kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox