From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E21D136E1A for ; Fri, 24 May 2024 23:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716592745; cv=none; b=UQqKC1WL9zmkh3SXs8F/e0K/1pso8Xm1USafPhWhEqAqySnjqtlUg3JD3Z1tCMIYjWzWiWRraR6DAil0l4Dv1llJaQsMs2d1jN7KYGdiES5vyrLkI26YQMhnzJQt7Lxzx+RX5VOjM62AKmYlyfE2qMviXv+0sMsMiqIkYJzflFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716592745; c=relaxed/simple; bh=8MVNeGCgrLKOpMxy79Vc3N1TPToSeyErrOMTtVInq4M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lgm6ulNQ3TgupECKH7p11OYPa6i5Dw/7TtyGaIXRQLZVxwZbP9/xcFKGtX6qKcXEOwEJbtgmWAvqaX8Yt3N/LC6soaI8AkWCsLqQfE3gl8eFEyBOX62BcGSr8tzYRtK3UoWLKkvF2vcr/avQ2KFsmgBc61usm5XhCbu4QR9aCg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=DGpVJ/OQ; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="DGpVJ/OQ" X-Envelope-To: geliang@kernel.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716592742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LIaWWJRJTRx/KqsZnMQfTTl+NFXMc1JDxx3JwdrNq+k=; b=DGpVJ/OQ4cmy6kmfguHHNtsezKoNyEH/DHDtliQ8S7DVd+Ua09opRbI5KioCA1NjEyRQcI 0UFuVNz9bfvcWTqJGPR/EUjxY4TgdOLSVWCduEZyZDafVMwsJEwvPRudzBhe0Ef/h9pusq Ecq1ALRoNbYHCbXRo/tHdndvkAojLBg= X-Envelope-To: andrii@kernel.org X-Envelope-To: eddyz87@gmail.com X-Envelope-To: mykolal@fb.com X-Envelope-To: ast@kernel.org X-Envelope-To: daniel@iogearbox.net X-Envelope-To: song@kernel.org X-Envelope-To: yonghong.song@linux.dev X-Envelope-To: john.fastabend@gmail.com X-Envelope-To: kpsingh@kernel.org X-Envelope-To: sdf@google.com X-Envelope-To: haoluo@google.com X-Envelope-To: jolsa@kernel.org X-Envelope-To: shuah@kernel.org X-Envelope-To: tanggeliang@kylinos.cn X-Envelope-To: bpf@vger.kernel.org X-Envelope-To: linux-kselftest@vger.kernel.org Message-ID: <6086c1fd-ad8d-4007-940a-537be39970bb@linux.dev> Date: Fri, 24 May 2024 16:18:55 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v4 0/6] use network helpers, part 5 To: Geliang Tang Cc: Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Geliang Tang , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org References: Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 5/23/24 8:21 PM, Geliang Tang wrote: > From: Geliang Tang > > This patchset uses post_socket_cb and post_connect_cb callbacks of struct > network_helper_opts to refactor do_test() in bpf_tcp_ca.c to move dctcp > test dedicated code out of do_test() into test_dctcp(). Overall looks good. It needs another respin. pw-bot: cr