From: John Fastabend <john.fastabend@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: bpf@vger.kernel.org, Cong Wang <cong.wang@bytedance.com>,
John Fastabend <john.fastabend@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jakub Sitnicki <jakub@cloudflare.com>,
Lorenz Bauer <lmb@cloudflare.com>
Subject: RE: [Patch bpf v2 7/7] skmsg: increase sk->sk_drops when dropping packets
Date: Tue, 25 May 2021 21:22:38 -0700 [thread overview]
Message-ID: <60adcd0ec9aa_3b75f208f0@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20210522191411.21446-8-xiyou.wangcong@gmail.com>
Cong Wang wrote:
> From: Cong Wang <cong.wang@bytedance.com>
>
> It is hard to observe packet drops without increase relevant
> drop counters, here we should increase sk->sk_drops which is
> a protocol-independent counter. Fortunately psock is always
> assocaited with a struct sock, we can just use psock->sk.
>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Jakub Sitnicki <jakub@cloudflare.com>
> Cc: Lorenz Bauer <lmb@cloudflare.com>
> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
[...]
> static void sk_psock_backlog(struct work_struct *work)
> {
> struct sk_psock *psock = container_of(work, struct sk_psock, work);
> @@ -617,7 +623,7 @@ static void sk_psock_backlog(struct work_struct *work)
> /* Hard errors break pipe and stop xmit. */
> sk_psock_report_error(psock, ret ? -ret : EPIPE);
> sk_psock_clear_state(psock, SK_PSOCK_TX_ENABLED);
> - kfree_skb(skb);
> + sock_drop(psock->sk, skb);
> goto end;
> }
> off += ret;
> @@ -625,7 +631,7 @@ static void sk_psock_backlog(struct work_struct *work)
> } while (len);
>
> if (!ingress)
> - kfree_skb(skb);
> + sock_drop(psock->sk, skb);
This is not a dropped skb this was sent via skb_send_sock().
The rest LGTM thanks.
prev parent reply other threads:[~2021-05-26 4:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 19:14 [Patch bpf v2 0/7] sock_map: some bug fixes and improvements Cong Wang
2021-05-22 19:14 ` [Patch bpf v2 1/7] skmsg: improve udp_bpf_recvmsg() accuracy Cong Wang
2021-05-22 19:14 ` [Patch bpf v2 2/7] selftests/bpf: Retry for EAGAIN in udp_redir_to_connected() Cong Wang
2021-05-22 19:14 ` [Patch bpf v2 3/7] udp: fix a memory leak in udp_read_sock() Cong Wang
2021-05-22 19:14 ` [Patch bpf v2 4/7] skmsg: fix a memory leak in sk_psock_verdict_apply() Cong Wang
2021-05-22 19:14 ` [Patch bpf v2 5/7] skmsg: teach sk_psock_verdict_apply() to return errors Cong Wang
2021-05-22 19:14 ` [Patch bpf v2 6/7] skmsg: pass source psock to sk_psock_skb_redirect() Cong Wang
2021-05-22 19:14 ` [Patch bpf v2 7/7] skmsg: increase sk->sk_drops when dropping packets Cong Wang
2021-05-26 4:22 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60adcd0ec9aa_3b75f208f0@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=jakub@cloudflare.com \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).