From: John Fastabend <john.fastabend@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net
Cc: andrii@kernel.org, kernel-team@fb.com
Subject: RE: [PATCH bpf-next] libbpf: add runtime APIs to query libbpf version
Date: Wed, 17 Nov 2021 20:58:14 -0800 [thread overview]
Message-ID: <6195dd6671071_2b4cc208ab@john.notmuch> (raw)
In-Reply-To: <20211118012018.2124797-1-andrii@kernel.org>
Andrii Nakryiko wrote:
> Libbpf provided LIBBPF_MAJOR_VERSION and LIBBPF_MINOR_VERSION macros to
> check libbpf version at compilation time. This doesn't cover all the
> needs, though, because version of libbpf that application is compiled
> against doesn't necessarily match the version of libbpf at runtime,
> especially if libbpf is used as a shared library.
>
> Add libbpf_major_version() and libbpf_minor_version() returning major
> and minor versions, respectively, as integers. Also add a convenience
> libbpf_version_string() for various tooling using libbpf to print out
> libbpf version in a human-readable form. Currently it will return
> "v0.6", but in the future it can contains some extra information, so the
> format itself is not part of a stable API and shouldn't be relied upon.
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> ---
LGTM.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2021-11-18 4:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 1:20 [PATCH bpf-next] libbpf: add runtime APIs to query libbpf version Andrii Nakryiko
2021-11-18 4:58 ` John Fastabend [this message]
2021-11-18 10:58 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6195dd6671071_2b4cc208ab@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox