From: bot+bpf-ci@kernel.org
To: sun.jian.kdev@gmail.com,andrii@kernel.org,shuah@kernel.org
Cc: eddyz87@gmail.com,ast@kernel.org,daniel@iogearbox.net,bpf@vger.kernel.org,linux-kselftest@vger.kernel.org,linux-kernel@vger.kernel.org,sun.jian.kdev@gmail.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev
Subject: Re: [PATCH 2/2] selftests/bpf: bpf_cookie: make perf_event subtest trigger reliably
Date: Fri, 27 Feb 2026 17:16:29 +0000 (UTC) [thread overview]
Message-ID: <61beeb55df97b37a0512ef24fcd44a184d241bbd66e33d636adcc2b05b75fa8f@mail.kernel.org> (raw)
In-Reply-To: <20260227164037.84110-3-sun.jian.kdev@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]
> Make burn_cpu() take a loop count and use a longer burn only for the
> perf_event subtest. Also scope perf_event_open() to the current task to
> avoid wasting samples on unrelated activity.
The second sentence here doesn't appear to match this commit's diff.
The perf_event_open() argument change from (attr, -1, 0, -1, flags)
to (attr, 0, -1, -1, flags) was made in the previous commit
e93098f90837 ("selftests/bpf: bpf_cookie: skip kprobe_multi tests
without bpf_testmod"), not in this one.
Should this sentence be dropped from the commit message, or moved
to the commit that actually makes the change?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/22495307331
AI-authorship-score: low
AI-authorship-explanation: Focused, minimal fix with idiomatic kernel patterns and natural commit message style consistent with human authorship.
issues-found: 1
issue-severity-score: low
issue-severity-explanation: Commit message claims a perf_event_open() scoping change that was actually made in the previous commit, not this one.
next prev parent reply other threads:[~2026-02-27 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 16:40 [PATCH 0/2] selftests/bpf: fix bpf_cookie failures Sun Jian
2026-02-27 16:40 ` [PATCH 1/2] selftests/bpf: bpf_cookie: skip kprobe_multi tests without bpf_testmod Sun Jian
2026-02-27 18:18 ` Alexei Starovoitov
2026-02-28 2:58 ` sun jian
2026-02-27 16:40 ` [PATCH 2/2] selftests/bpf: bpf_cookie: make perf_event subtest trigger reliably Sun Jian
2026-02-27 17:16 ` bot+bpf-ci [this message]
2026-03-01 19:59 ` Emil Tsalapatis
2026-03-02 2:24 ` sun jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61beeb55df97b37a0512ef24fcd44a184d241bbd66e33d636adcc2b05b75fa8f@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=shuah@kernel.org \
--cc=sun.jian.kdev@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox