From: John Fastabend <john.fastabend@gmail.com>
To: Martin KaFai Lau <kafai@fb.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com
Subject: RE: [PATCH bpf-next 0/3] Remove libcap dependency from bpf selftests
Date: Tue, 15 Mar 2022 23:20:44 -0700 [thread overview]
Message-ID: <623181bc1eb4f_18dc208a6@john.notmuch> (raw)
In-Reply-To: <20220316014841.2255248-1-kafai@fb.com>
Martin KaFai Lau wrote:
> After upgrading to the newer libcap (>= 2.60),
> the libcap commit aca076443591 ("Make cap_t operations thread safe.")
> added a "__u8 mutex;" to the "struct _cap_struct". It caused a few byte
> shift that breaks the assumption made in the "struct libcap" definition
> in test_verifier.c.
>
> This set is to remove the libcap dependency from the bpf selftests.
>
> Martin KaFai Lau (3):
> bpf: selftests: Add helpers to directly use the capget and capset
> syscall
> bpf: selftests: Remove libcap usage from test_verifier
> bpf: selftests: Remove libcap usage from test_progs
>
> tools/testing/selftests/bpf/Makefile | 8 +-
> tools/testing/selftests/bpf/cap_helpers.c | 68 ++++++++++++++
> tools/testing/selftests/bpf/cap_helpers.h | 10 +++
> .../selftests/bpf/prog_tests/bind_perm.c | 45 ++--------
> tools/testing/selftests/bpf/test_verifier.c | 89 ++++++-------------
> 5 files changed, 118 insertions(+), 102 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/cap_helpers.c
> create mode 100644 tools/testing/selftests/bpf/cap_helpers.h
>
> --
> 2.30.2
>
For the series,
Acked-by: John Fastabend <john.fastabend@gmail.com>
prev parent reply other threads:[~2022-03-16 6:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 1:48 [PATCH bpf-next 0/3] Remove libcap dependency from bpf selftests Martin KaFai Lau
2022-03-16 1:48 ` [PATCH bpf-next 1/3] bpf: selftests: Add helpers to directly use the capget and capset syscall Martin KaFai Lau
2022-03-16 6:17 ` John Fastabend
2022-03-16 1:48 ` [PATCH bpf-next 2/3] bpf: selftests: Remove libcap usage from test_verifier Martin KaFai Lau
2022-03-17 2:18 ` Shung-Hsi Yu
2022-03-17 7:04 ` Shung-Hsi Yu
2022-03-16 1:49 ` [PATCH bpf-next 3/3] bpf: selftests: Remove libcap usage from test_progs Martin KaFai Lau
2022-03-16 15:14 ` sdf
2022-03-16 5:36 ` [PATCH bpf-next 0/3] Remove libcap dependency from bpf selftests Andrii Nakryiko
2022-03-16 17:17 ` Martin KaFai Lau
2022-03-16 6:20 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=623181bc1eb4f_18dc208a6@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox