From: Hari Bathini <hbathini@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH v3 5/5] powerpc/bpf: use patch_instructions()
Date: Fri, 25 Aug 2023 23:13:00 +0530 [thread overview]
Message-ID: <62ca8ed7-8ae6-19ed-44a4-e8eec453d35f@linux.ibm.com> (raw)
In-Reply-To: <5f41d2e4-878b-1c0b-f888-96b977065207@csgroup.eu>
On 25/08/23 9:16 pm, Christophe Leroy wrote:
>
>
> Le 25/08/2023 à 17:18, Hari Bathini a écrit :
>> Use the newly introduced patch_instructions() that handles patching
>> multiple instructions with one call. This improves speed of exectution
>> for JIT'ing bpf programs.
>>
>> Without this patch (on a POWER9 lpar):
>>
>> # time modprobe test_bpf
>> real 2m59.681s
>> user 0m0.000s
>> sys 1m44.160s
>> #
>>
>> With this patch (on a POWER9 lpar):
>>
>> # time modprobe test_bpf
>> real 0m5.013s
>> user 0m0.000s
>> sys 0m4.216s
>> #
>
> Right, significant improvement. Forget by comment to patch 1, I should
> have read the series up to the end. Just wondering why you don't just
> put patch 4 up front ?
I wanted to remove the dependency for bpf_prog_pack enablement
patches with this improvement, just in case..
- Hari
prev parent reply other threads:[~2023-08-25 17:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 15:18 [PATCH 0/5] powerpc/bpf: use BPF prog pack allocator Hari Bathini
2023-08-25 15:18 ` [PATCH v3 1/5] powerpc/bpf: implement bpf_arch_text_copy Hari Bathini
2023-08-25 15:29 ` Christophe Leroy
2023-08-25 15:18 ` [PATCH v3 2/5] powerpc/bpf: implement bpf_arch_text_invalidate for bpf_prog_pack Hari Bathini
2023-08-25 15:33 ` Christophe Leroy
2023-08-25 17:37 ` Hari Bathini
2023-08-25 15:18 ` [PATCH v3 3/5] powerpc/bpf: use bpf_jit_binary_pack_[alloc|finalize|free] Hari Bathini
2023-08-25 15:18 ` [PATCH v3 4/5] powerpc/code-patching: introduce patch_instructions() Hari Bathini
2023-08-25 15:18 ` [PATCH v3 5/5] powerpc/bpf: use patch_instructions() Hari Bathini
2023-08-25 15:46 ` Christophe Leroy
2023-08-25 17:43 ` Hari Bathini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ca8ed7-8ae6-19ed-44a4-e8eec453d35f@linux.ibm.com \
--to=hbathini@linux.ibm.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@iogearbox.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox