From: John Fastabend <john.fastabend@gmail.com>
To: Shmulik Ladkani <shmulik@metanetworks.com>,
bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Stanislav Fomichev <sdf@google.com>
Cc: Jakub Sitnicki <jakub@cloudflare.com>,
Petar Penkov <ppenkov@google.com>,
Willem de Bruijn <willemb@google.com>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>
Subject: RE: [PATCH v2 bpf-next 0/4] flow_dissector: Allow bpf flow-dissector progs to request fallback to normal dissection
Date: Tue, 23 Aug 2022 00:38:24 -0700 [thread overview]
Message-ID: <630483f08be3e_2ad4d720887@john.notmuch> (raw)
In-Reply-To: <20220821113519.116765-1-shmulik.ladkani@gmail.com>
Shmulik Ladkani wrote:
> Currently, attaching BPF_PROG_TYPE_FLOW_DISSECTOR programs completely
> replaces the flow-dissector logic with custom dissection logic.
> This forces implementors to write programs that handle dissection for
> any flows expected in the namespace.
>
> It makes sense for flow-dissector bpf programs to just augment the
> dissector with custom logic (e.g. dissecting certain flows or custom
> protocols), while enjoying the broad capabilities of the standard
> dissector for any other traffic.
>
> v2:
> - Extend selftests/bpf/progs/bpf_flow.c to exercise new ret code
>
> Shmulik Ladkani (4):
> flow_dissector: Make 'bpf_flow_dissect' return the bpf program retcode
> bpf/flow_dissector: Introduce BPF_FLOW_DISSECTOR_CONTINUE retcode for
> flow-dissector bpf progs
> bpf: test_run: Propagate bpf_flow_dissect's retval to user's
> bpf_attr.test.retval
> selftests/bpf: test BPF_FLOW_DISSECTOR_CONTINUE
>
> include/linux/skbuff.h | 4 +-
> include/uapi/linux/bpf.h | 5 +++
> net/core/flow_dissector.c | 16 ++++---
> tools/include/uapi/linux/bpf.h | 5 +++
> .../selftests/bpf/prog_tests/flow_dissector.c | 44 ++++++++++++++++++-
> .../prog_tests/flow_dissector_load_bytes.c | 2 +-
> tools/testing/selftests/bpf/progs/bpf_flow.c | 15 +++++++
> .../selftests/bpf/test_flow_dissector.sh | 8 ++++
> 8 files changed, 89 insertions(+), 10 deletions(-)
>
> --
> 2.37.2
>
LGTM.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2022-08-23 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 11:35 [PATCH v2 bpf-next 0/4] flow_dissector: Allow bpf flow-dissector progs to request fallback to normal dissection Shmulik Ladkani
2022-08-21 11:35 ` [PATCH v2 bpf-next 1/4] flow_dissector: Make 'bpf_flow_dissect' return the bpf program retcode Shmulik Ladkani
2022-08-21 11:35 ` [PATCH v2 bpf-next 2/4] bpf/flow_dissector: Introduce BPF_FLOW_DISSECTOR_CONTINUE retcode for flow-dissector bpf progs Shmulik Ladkani
2022-08-21 11:35 ` [PATCH v2 bpf-next 3/4] bpf: test_run: Propagate bpf_flow_dissect's retval to user's bpf_attr.test.retval Shmulik Ladkani
2022-08-21 11:35 ` [PATCH v2 bpf-next 4/4] selftests/bpf: test BPF_FLOW_DISSECTOR_CONTINUE Shmulik Ladkani
2022-08-22 18:06 ` [PATCH v2 bpf-next 0/4] flow_dissector: Allow bpf flow-dissector progs to request fallback to normal dissection Stanislav Fomichev
2022-08-23 7:38 ` John Fastabend [this message]
2022-08-23 20:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=630483f08be3e_2ad4d720887@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jakub@cloudflare.com \
--cc=ppenkov@google.com \
--cc=sdf@google.com \
--cc=shmulik.ladkani@gmail.com \
--cc=shmulik@metanetworks.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox