From: John Fastabend <john.fastabend@gmail.com>
To: Florian Lehner <dev@der-flo.net>, bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net,
kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yhs@fb.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org,
Florian Lehner <dev@der-flo.net>
Subject: RE: [PATCH bpf-next v2] bpf: check max_entries before allocating memory
Date: Fri, 28 Oct 2022 16:20:52 -0700 [thread overview]
Message-ID: <635c63d4d8ad2_b1ba20896@john.notmuch> (raw)
In-Reply-To: <20221028183405.59554-1-dev@der-flo.net>
Florian Lehner wrote:
> For maps of type BPF_MAP_TYPE_CPUMAP memory is allocated first before
> checking the max_entries argument. If then max_entries is greater than
> NR_CPUS additional work needs to be done to free allocated memory before
> an error is returned.
> This changes moves the check on max_entries before the allocation
> happens.
>
> Signed-off-by: Florian Lehner <dev@der-flo.net>
> ---
LGTM.
Acked-by: John Fastabend <john.fastabend@gmail.com>
prev parent reply other threads:[~2022-10-28 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 18:34 [PATCH bpf-next v2] bpf: check max_entries before allocating memory Florian Lehner
2022-10-28 23:00 ` patchwork-bot+netdevbpf
2022-10-28 23:20 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=635c63d4d8ad2_b1ba20896@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dev@der-flo.net \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox