From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ADF8C433F5 for ; Fri, 25 Feb 2022 18:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231835AbiBYSCT (ORCPT ); Fri, 25 Feb 2022 13:02:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231730AbiBYSCR (ORCPT ); Fri, 25 Feb 2022 13:02:17 -0500 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F2142510F5 for ; Fri, 25 Feb 2022 10:01:43 -0800 (PST) Received: by mail-il1-x12a.google.com with SMTP id d3so4886904ilr.10 for ; Fri, 25 Feb 2022 10:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jmPNe5w2igTeTdG9i+t0C+LJ8u5o2P/TYchcIcjneOM=; b=UAtesJgznmZkD5fCGtm7cVlSmUmJT0RNZpejtSXRc54OGmXFBgYOWb/Wup7KhHpZKC 6KWhHF8W1G1Ar4MY86dZ37zqxQGpS7toDNK1lTeVdbPXk6nEldKmki8uV/GjOhMvxQXK Iv7jJ7uL0UjIyqHbsp9eAtA8Hy4HY5ToJCNJo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jmPNe5w2igTeTdG9i+t0C+LJ8u5o2P/TYchcIcjneOM=; b=CsiXNRKp0HGKBtpXPIyf8PZOflDGRD5b1MY3GCwvUDxo1jCaFczdkmSmAg0fXGnaSG XZ3RzroB0Q3CiSQmXqWUKxL6KvN8gA1SGmGcW/Xhz4wIgNaa7hxTohZQAJs9BIbIqlaI 84vS4tcRLLoRkp+VKoI+XlWrCKqXRrASb41yuQtu2cdLrzbLGkAuUHzgeiQT4MB2+xtr l9swsCh1fkVl1ASkiW3ldx1jdwBp+bKNuIiUz5g91rFprTnx5ROjmaYiIEv/e85ORtRA ZboF1yTgRN9JvfYanL9AmUV3NbPZgT84U3lAmd1x475wNN6mXSuVc0gwNagZ+F+wlRkh OKMw== X-Gm-Message-State: AOAM533mpuRr3/EXRcbz7OW0jcV4lfdZKDrUeKF2lC1udkNJs7MqSj4f JQk80wmqKnL78qZ5Ek3J4gKQvg== X-Google-Smtp-Source: ABdhPJyeoCYCoIZbD+oRa0e576ynpqdPVl3oq4IN0xpZ37BARybE4JvNHHYpQXh+IBx1zozXaExyNA== X-Received: by 2002:a05:6e02:178b:b0:2c2:81f5:3cbb with SMTP id y11-20020a056e02178b00b002c281f53cbbmr7469031ilu.296.1645812102498; Fri, 25 Feb 2022 10:01:42 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id a2-20020a056e02120200b002c21a18437csm1932389ilq.40.2022.02.25.10.01.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 10:01:42 -0800 (PST) Subject: Re: [PATCH V2] selftests: Fix build when $(O) points to a relative path To: Muhammad Usama Anjum , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh Cc: kernel@collabora.com, kernelci@groups.io, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Shuah Khan References: <20220216223817.1386745-1-usama.anjum@collabora.com> <46489cd9-fb7a-5a4b-7f36-1c9f6566bd93@collabora.com> From: Shuah Khan Message-ID: <63870982-62ba-97f2-5ee2-d4457a7a5cdb@linuxfoundation.org> Date: Fri, 25 Feb 2022 11:01:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <46489cd9-fb7a-5a4b-7f36-1c9f6566bd93@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 2/25/22 10:22 AM, Muhammad Usama Anjum wrote: > Any thoughts about it? > No to post please. > On 2/17/22 3:38 AM, Muhammad Usama Anjum wrote: >> Build of bpf and tc-testing selftests fails when the relative path of >> the build directory is specified. >> >> make -C tools/testing/selftests O=build0 >> make[1]: Entering directory '/linux_mainline/tools/testing/selftests/bpf' >> ../../../scripts/Makefile.include:4: *** O=build0 does not exist. Stop. >> make[1]: Entering directory '/linux_mainline/tools/testing/selftests/tc-testing' >> ../../../scripts/Makefile.include:4: *** O=build0 does not exist. Stop. >> >> Makefiles of bpf and tc-testing include scripts/Makefile.include file. >> This file has sanity checking inside it which checks the output path. >> The output path is not relative to the bpf or tc-testing. The sanity >> check fails. Expand the output path to get rid of this error. The fix is >> the same as mentioned in commit 150a27328b68 ("bpf, preload: Fix build >> when $(O) points to a relative path"). >> >> Signed-off-by: Muhammad Usama Anjum >> --- >> Changes in V2: >> Add more explaination to the commit message. >> Support make install as well. Looks god to me. I can pull this in for Linux 5.18-rc1 thanks, -- Shuah