From: John Fastabend <john.fastabend@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net
Cc: andrii@kernel.org, kernel-team@fb.com
Subject: RE: [PATCH bpf-next 2/2] selftests/bpf: convert dynptr_fail and map_kptr_fail subtests to generic tester
Date: Tue, 06 Dec 2022 22:27:52 -0800 [thread overview]
Message-ID: <63903268f0b37_bb3620873@john.notmuch> (raw)
In-Reply-To: <20221206011159.1208452-2-andrii@kernel.org>
Andrii Nakryiko wrote:
> Convert big chunks of dynptr and map_kptr subtests to use generic
> verification_tester. They are switched from using manually maintained
> tables of test cases, specifying program name and expected error
> verifier message, to btf_decl_tag-based annotations directly on
> corresponding BPF programs: __failure to specify that BPF program is
> expected to fail verification, and __msg() to specify expected log
> message.
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> ---
Nice.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2022-12-07 6:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 1:11 [PATCH bpf-next 1/2] selftests/bpf: add generic BPF program verification tester Andrii Nakryiko
2022-12-06 1:11 ` [PATCH bpf-next 2/2] selftests/bpf: convert dynptr_fail and map_kptr_fail subtests to generic tester Andrii Nakryiko
2022-12-07 6:27 ` John Fastabend [this message]
2022-12-07 4:43 ` [PATCH bpf-next 1/2] selftests/bpf: add generic BPF program verification tester Alexei Starovoitov
2022-12-07 19:46 ` Andrii Nakryiko
2022-12-07 6:21 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63903268f0b37_bb3620873@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox