From: John Fastabend <john.fastabend@gmail.com>
To: Pramukh Naduthota <pnaduthota@google.com>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org
Subject: Re: [PATCH net-next v2 2/2] Add a selftest for devmap pinning.
Date: Tue, 06 Dec 2022 22:43:24 -0800 [thread overview]
Message-ID: <6390360cb92fe_bb36208c5@john.notmuch> (raw)
In-Reply-To: <CAEeqUsrLqtxvQeKLdDe0xAc_zTM__0wuJ4Vqta+cUzQe5fuNew@mail.gmail.com>
Pramukh Naduthota wrote:
> Sorry, looks like I didn't run the tests again after fixing my
> checkpatch errors. Still new to this, and am quite mortified.
>
> Is there a better way to fix this than sending out a v3 of my patch?
You'll need to send a v3 and be sure to build/run the selftests. Also for
future reference please don't top post it. And thanks for working
on the fix.
prev parent reply other threads:[~2022-12-07 6:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 1:11 [PATCH net-next v2 0/2] Fix pinning devmaps Pramukh Naduthota
2022-12-01 1:11 ` [PATCH net-next v2 1/2] Ignore RDONLY_PROG for devmaps in libbpf to allow re-loading of pinned devmaps Pramukh Naduthota
2022-12-01 1:11 ` [PATCH net-next v2 2/2] Add a selftest for devmap pinning Pramukh Naduthota
2022-12-05 22:31 ` Daniel Borkmann
2022-12-07 0:42 ` Pramukh Naduthota
2022-12-07 6:43 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6390360cb92fe_bb36208c5@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=pnaduthota@google.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox